Project

General

Profile

Actions

Bug #5066

closed

Missing dependency on which

Added by Lionel Le Folgoc about 8 years ago. Updated over 7 years ago.

Status:
Released
Priority:
1
Category:
Packaging
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:

Description

Hi again again,

In rudder-agent-thin (maybe rudder-agent too), /opt/rudder/bin/run-inventory calls the "which" command:

[... blablabla]
if [ -x /opt/rudder/bin/perl ]; then
[...]
elif which fusioninventory-agent > /dev/null 2>&1; then
[...]
else

  # No usable FusionInventory installation has been detected, bail out.
  echo "[ERROR] No usable FusionInventory instance (either from Rudder or the system) detected." 
  exit 1

fi

The test was failing here because the "which" package wasn't installed. Maybe it's worth adding a dependency?

Thanks.

Actions #1

Updated by Lionel Le Folgoc about 8 years ago

RHEL-6, as usual. ;-)

Actions #2

Updated by Matthieu CERDA about 8 years ago

  • Status changed from New to In progress
  • Assignee set to Matthieu CERDA
  • Priority changed from N/A to 1
  • Target version set to 2.11.0~beta2

Taking this.

Actions #3

Updated by Matthieu CERDA about 8 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Matthieu CERDA to Jonathan CLARKE
  • % Done changed from 0 to 100
  • Pull Request set to https://github.com/Normation/rudder-packages/pull/384

PR is ready, used "command" POSIX builtin instead of which, see => http://stackoverflow.com/questions/592620/how-to-check-if-a-program-exists-from-a-bash-script

Actions #4

Updated by Matthieu CERDA about 8 years ago

  • Status changed from Pending technical review to Pending release

Applied in changeset commit:a08c459316844906708d323906dabd32d30aabb1.

Actions #5

Updated by Jonathan CLARKE about 8 years ago

Applied in changeset commit:cb8c7cbd84b9427a067645e98813ad531b8b2f41.

Actions #6

Updated by Vincent MEMBRÉ almost 8 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.11.0~beta2 (announcement , changelog), which were released today.

Actions #7

Updated by Benoît PECCATTE over 7 years ago

  • Project changed from 34 to Rudder
  • Category set to Packaging
Actions

Also available in: Atom PDF