Project

General

Profile

Actions
Copy link

Bug #5148

closed

Use of bundle "file_ensure_line_present_in_ini_section.cf" to add lines into a section which does not exist will only add the section, not the lines

Added by Nicolas PERRON over 10 years ago. Updated over 2 years ago.

Status:
Released
Priority:
N/A
Assignee:
Jonathan CLARKE
Category:
Generic methods
Target version:
ncf-0.x
Pull Request:
https://github.com/Normation/ncf/pull/76
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
Fix check:
Regression:

Description

The use of file_ensure_line_present_in_ini_section.cf will only works if the section already exist and is not at the end of the file.
For example, to add a line in the section [my_section2]:
It will not work with a file containing:

[my_section1]

or 
[my_section1]
[my_section2]

It will work with a file containing:

[my_section1]
[my_section2]

or
[my_section1]
[my_section2]
#A comment

Actions
Copy link
 #1

Updated by Nicolas PERRON over 10 years ago

  • % Done changed from 0 to 90
  • Pull Request set to https://github.com/Normation/ncf/pull/76
Actions
Copy link
 #2

Updated by Nicolas PERRON over 10 years ago

  • Status changed from New to Pending technical review
  • Assignee set to Jonathan CLARKE
  • % Done changed from 90 to 100

Previous test improved !

Jon, Nico, could you review it please ?

Actions
Copy link
 #3

Updated by Nicolas PERRON over 10 years ago

  • Status changed from Pending technical review to Pending release
Actions
Copy link
 #5

Updated by Vincent MEMBRÉ over 8 years ago

  • Status changed from Pending release to Released
Actions
Copy link
 #6

Updated by Alexis Mousset over 2 years ago

  • Target version changed from 0.x to ncf-0.x
  • Priority set to 0
Actions
Copy link
 #7

Updated by Alexis Mousset over 2 years ago

  • Project changed from 41 to Rudder
  • Category set to Generic methods
Actions
Copy link

Also available in: Atom PDF