Project

General

Profile

Actions
Copy link

Bug #5203

closed

There is no way to remove a Directive based on a Technique that no longer exists

Added by Matthieu CERDA over 10 years ago. Updated about 7 years ago.

Status:
Released
Priority:
4
Assignee:
Vincent MEMBRÉ
Category:
Web - Config management
Target version:
3.1.24
Pull Request:
https://github.com/Normation/rudder/p...
Severity:
Major - prevents use of part of Rudder | no simple workaround
UX impact:
User visibility:
Getting started - demo | first install | level 1 Techniques
Effort required:
Priority:
60
Name check:
Fix check:
Regression:

Description

I tried to update my Techniques, but in the process also removed a Technique that was here before (a custom one).

Problem is, the deployement does not work anymore, and I can not remove the Directive that breaks it as there is no more a Delete button :)

Please see the attached screenshot.

Files

Download all files
oops.png (32.1 KB) oops.png Broken directive without delete button Matthieu CERDA, 2014-07-02 17:11
2017-10-18_18.24.04-Rudder_-_Directives_Management.png (124 KB) 2017-10-18_18.24.04-Rudder_-_Directives_Management.png No version of the Technique available François ARMAND, 2017-10-18 18:55
2017-10-18_18.52.41-Rudder_-_Directives_Management.png (148 KB) 2017-10-18_18.52.41-Rudder_-_Directives_Management.png Automatic migration toward most recent available version François ARMAND, 2017-10-18 18:55

Related issues 4 (0 open — 4 closed)

Related to Rudder - Bug #5366: Deleting a Technique from ncf-builder will not remove Technique from RudderRejectedActions
Related to Rudder - Bug #5808: Correctly display technique removed from source libraryReleasedNicolas CHARLES2014-11-24Actions
Related to Rudder - Bug #11649: No way to delete stale entries from the Reference Technique libraryRejectedActions
Has duplicate Rudder - Bug #6191: Allow to migrate or delete Directive based on a missing TechniqueRejectedActions
Actions
Copy link
 #1

Updated by Matthieu CERDA over 10 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Matthieu CERDA over 10 years ago

For me, the error under "About this Directive" is relevant and needs to stay. However, the message at the botton is meaningless for an end user, duplicates what is "nicely" said in the upper one and should maybe be replaced by a "migrate to another version or delete" choice :)

I did not verify if the same problem happens if there is another version available for this Technique, the behavior might not be the same ?

Actions
Copy link
 #3

Updated by François ARMAND over 10 years ago

  • Priority changed from 2 to 4

I think I agree with the qualification.
I'm not sure where the error message should go, but clearly, we have to provide the user with a way to get out of that situation (without relying on any LDAP/cmd line wizardry).

The very first step seems to let the promise generation process runs even in that case. We could for example disable directives with broken techniques.

The second step is to allow to delete the directive. Migration would be nice but may be more difficult.

The good news it that there is a simple workaround: just revert the commit that removed the Technique, then reload Techniques library, then delete Directives based on the Technique, the delete back the Technique.

I lowered the priority to 4 because 1/ it is not a really frequent use case and 2/ the workaround is simple.

Actions
Copy link
 #4

Updated by Nicolas PERRON over 10 years ago

  • Target version changed from 2.10.4 to 2.10.5
Actions
Copy link
 #5

Updated by Vincent MEMBRÉ about 10 years ago

  • Target version changed from 2.10.5 to 2.10.6
Actions
Copy link
 #6

Updated by Matthieu CERDA about 10 years ago

  • Target version changed from 2.10.6 to 2.10.7
Actions
Copy link
 #7

Updated by Vincent MEMBRÉ about 10 years ago

  • Target version changed from 2.10.7 to 2.10.8
Actions
Copy link
 #8

Updated by Vincent MEMBRÉ almost 10 years ago

  • Target version changed from 2.10.8 to 2.10.9
Actions
Copy link
 #9

Updated by Vincent MEMBRÉ almost 10 years ago

  • Target version changed from 2.10.9 to 2.10.10
Actions
Copy link
 #10

Updated by Vincent MEMBRÉ almost 10 years ago

  • Target version changed from 2.10.10 to 2.10.11
Actions
Copy link
 #11

Updated by Vincent MEMBRÉ over 9 years ago

  • Target version changed from 2.10.11 to 2.10.12
Actions
Copy link
 #12

Updated by Vincent MEMBRÉ over 9 years ago

  • Target version changed from 2.10.12 to 2.10.13
Actions
Copy link
 #13

Updated by Benoît PECCATTE over 9 years ago

  • Status changed from 8 to New
Actions
Copy link
 #14

Updated by Vincent MEMBRÉ over 9 years ago

  • Target version changed from 2.10.13 to 2.10.14
Actions
Copy link
 #15

Updated by Vincent MEMBRÉ over 9 years ago

  • Target version changed from 2.10.14 to 2.10.15
Actions
Copy link
 #16

Updated by Vincent MEMBRÉ over 9 years ago

  • Target version changed from 2.10.15 to 2.10.16
Actions
Copy link
 #17

Updated by Vincent MEMBRÉ over 9 years ago

  • Target version changed from 2.10.16 to 2.10.17
Actions
Copy link
 #18

Updated by Vincent MEMBRÉ about 9 years ago

  • Target version changed from 2.10.17 to 2.10.18
Actions
Copy link
 #19

Updated by Vincent MEMBRÉ about 9 years ago

  • Target version changed from 2.10.18 to 2.10.19
Actions
Copy link
 #20

Updated by Vincent MEMBRÉ about 9 years ago

  • Target version changed from 2.10.19 to 2.10.20
Actions
Copy link
 #21

Updated by Vincent MEMBRÉ almost 9 years ago

  • Target version changed from 2.10.20 to 277
Actions
Copy link
 #22

Updated by Vincent MEMBRÉ almost 9 years ago

  • Target version changed from 277 to 2.11.18
Actions
Copy link
 #23

Updated by Vincent MEMBRÉ almost 9 years ago

  • Target version changed from 2.11.18 to 2.11.19
Actions
Copy link
 #24

Updated by Vincent MEMBRÉ over 8 years ago

  • Target version changed from 2.11.19 to 2.11.20
Actions
Copy link
 #25

Updated by Vincent MEMBRÉ over 8 years ago

  • Target version changed from 2.11.20 to 2.11.21
Actions
Copy link
 #26

Updated by Vincent MEMBRÉ over 8 years ago

  • Target version changed from 2.11.21 to 2.11.22
Actions
Copy link
 #27

Updated by Vincent MEMBRÉ over 8 years ago

  • Target version changed from 2.11.22 to 2.11.23
Actions
Copy link
 #28

Updated by Vincent MEMBRÉ over 8 years ago

  • Target version changed from 2.11.23 to 2.11.24
Actions
Copy link
 #29

Updated by Vincent MEMBRÉ about 8 years ago

  • Target version changed from 2.11.24 to 308
Actions
Copy link
 #30

Updated by Vincent MEMBRÉ about 8 years ago

  • Target version changed from 308 to 3.1.14
Actions
Copy link
 #31

Updated by Vincent MEMBRÉ about 8 years ago

  • Target version changed from 3.1.14 to 3.1.15
Actions
Copy link
 #32

Updated by Vincent MEMBRÉ about 8 years ago

  • Target version changed from 3.1.15 to 3.1.16
Actions
Copy link
 #33

Updated by Vincent MEMBRÉ about 8 years ago

  • Target version changed from 3.1.16 to 3.1.17
Actions
Copy link
 #34

Updated by Vincent MEMBRÉ almost 8 years ago

  • Target version changed from 3.1.17 to 3.1.18
Actions
Copy link
 #35

Updated by Vincent MEMBRÉ almost 8 years ago

  • Target version changed from 3.1.18 to 3.1.19
Actions
Copy link
 #36

Updated by François ARMAND over 7 years ago

  • Severity set to Major - prevents use of part of Rudder | no simple workaround
  • User visibility set to Getting started - demo | first install | level 1 Techniques
  • Priority set to 45
Actions
Copy link
 #37

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.1.19 to 3.1.20
Actions
Copy link
 #38

Updated by Jonathan CLARKE over 7 years ago

  • Assignee deleted (François ARMAND)
Actions
Copy link
 #39

Updated by Benoît PECCATTE over 7 years ago

Tested in 4.1, this bug is still there

Actions
Copy link
 #40

Updated by Benoît PECCATTE over 7 years ago

when we detect this we should have a simple page that contains : "Please bring back the technique via git or click this button to remove the directive from Rudder"

Actions
Copy link
 #41

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.1.20 to 3.1.21
Actions
Copy link
 #42

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.1.21 to 3.1.22
Actions
Copy link
 #43

Updated by Benoît PECCATTE over 7 years ago

  • Priority changed from 45 to 58
Actions
Copy link
 #44

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.1.22 to 3.1.23
  • Priority changed from 58 to 59
Actions
Copy link
 #45

Updated by Vincent MEMBRÉ about 7 years ago

  • Target version changed from 3.1.23 to 3.1.24
Actions
Copy link
 #46

Updated by Benoît PECCATTE about 7 years ago

  • Assignee set to François ARMAND
  • Priority changed from 59 to 60
Actions
Copy link Download all files
 #47

Updated by François ARMAND about 7 years ago

The proposed change allows to delete a Directive when no version of the technique is availabe at all:

No version of the Technique available

When at least one version of the technique is available, a migration towards it is done with that warning message:

Automatic migration toward most recent available version

Actions
Copy link
 #48

Updated by François ARMAND about 7 years ago

  • Status changed from New to In progress
Actions
Copy link
 #49

Updated by François ARMAND about 7 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/1760
Actions
Copy link
 #50

Updated by François ARMAND about 7 years ago

  • Status changed from Pending technical review to Pending release
Actions
Copy link
 #51

Updated by François ARMAND about 7 years ago

  • Related to Bug #6191: Allow to migrate or delete Directive based on a missing Technique added
Actions
Copy link
 #52

Updated by François ARMAND about 7 years ago

  • Related to deleted (Bug #6191: Allow to migrate or delete Directive based on a missing Technique)
Actions
Copy link
 #53

Updated by François ARMAND about 7 years ago

  • Has duplicate Bug #6191: Allow to migrate or delete Directive based on a missing Technique added
Actions
Copy link
 #54

Updated by François ARMAND about 7 years ago

  • Related to Bug #11649: No way to delete stale entries from the Reference Technique library added
Actions
Copy link
 #55

Updated by Vincent MEMBRÉ about 7 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 3.1.24, 4.1.8 and 4.2.1 which were released today.

Actions
Copy link

Also available in: Atom PDF