Project

General

Profile

Actions

Bug #5221

closed

The ncf api hooks should not log unneeded things and need cleanup

Added by Matthieu CERDA almost 8 years ago. Updated over 7 years ago.

Status:
Released
Priority:
2
Category:
Packaging
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:

Description

During hook execution (done in the API context), everything executed is outputted in Apache logs.

So, we don't want things like curl output or git output cluttering our logs !

Also, the hooks need sooner than later a quick shellcheck verification :)

Actions #1

Updated by Matthieu CERDA almost 8 years ago

  • Subject changed from The ncf api hooks should not log unneeded things to The ncf api hooks should not log unneeded things and need cleanup
  • Description updated (diff)
Actions #2

Updated by Matthieu CERDA almost 8 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Matthieu CERDA to Jonathan CLARKE
  • % Done changed from 0 to 100
  • Pull Request set to https://github.com/Normation/rudder-packages/pull/438

PR is ready !

Actions #3

Updated by Matthieu CERDA almost 8 years ago

  • Status changed from Pending technical review to Pending release

Applied in changeset commit:f2e2a562206acf519063575aa21d190519acc851.

Actions #4

Updated by Jonathan CLARKE almost 8 years ago

Applied in changeset commit:ba5c11d961a6d0e4921fb9ca905dbf51ca13699d.

Actions #5

Updated by Vincent MEMBRÉ almost 8 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.11.0~rc1 (announcement , changelog), which was released today.

Actions #6

Updated by Benoît PECCATTE over 7 years ago

  • Project changed from 34 to Rudder
  • Category set to Packaging
Actions

Also available in: Atom PDF