Project

General

Profile

Actions

Bug #5243

closed

Error in parsing of bundle names causing ncf to use technique names like "ntp {"

Added by Jonathan CLARKE about 8 years ago. Updated 4 months ago.

Status:
Released
Priority:
4
Category:
Generic methods
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Regression:

Description

This has an impact on the ncf Python lib, the ncf-api and therefore ncf-builder.

The culprit is a badly formed regex in ncf.py:

match = re.match("[^#]*bundle\s+agent\s+([^(]+)\(?([^)]*)\)?.*$", line)

This matches " }" as part of the name.


Subtasks 1 (0 open1 closed)

Bug #5245: simplify regexp to parse bundle nameReleasedFrançois ARMANDActions
Actions #1

Updated by Jonathan CLARKE about 8 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Jonathan CLARKE to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/ncf/pull/84
Actions #2

Updated by François ARMAND about 8 years ago

  • Assignee changed from Vincent MEMBRÉ to François ARMAND

Taking it.

Tested with online regex tester, seems ok.

Actions #3

Updated by Jonathan CLARKE about 8 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Applied in changeset commit:85df0e94a26cdb72531b0682521e2adce5fa514e.

Actions #4

Updated by François ARMAND about 8 years ago

Applied in changeset commit:0deb97debc67bd6103f0ab892d10bdc61a3d389f.

Actions #5

Updated by Benoît PECCATTE over 7 years ago

  • Target version set to 0.x
Actions #6

Updated by Vincent MEMBRÉ about 6 years ago

  • Status changed from Pending release to Released
Actions #7

Updated by Alexis Mousset 4 months ago

  • Target version changed from 0.x to ncf-0.x
  • Priority set to 0
Actions #8

Updated by Alexis Mousset 4 months ago

  • Project changed from 41 to Rudder
  • Category set to Generic methods
Actions

Also available in: Atom PDF