Actions
Bug #5243
closed
Error in parsing of bundle names causing ncf to use technique names like "ntp {"
Pull Request:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
Fix check:
Regression:
Description
This has an impact on the ncf Python lib, the ncf-api and therefore ncf-builder.
The culprit is a badly formed regex in ncf.py:
match = re.match("[^#]*bundle\s+agent\s+([^(]+)\(?([^)]*)\)?.*$", line)
This matches " }" as part of the name.
Updated by Jonathan CLARKE over 10 years ago
- Status changed from In progress to Pending technical review
- Assignee changed from Jonathan CLARKE to Vincent MEMBRÉ
- Pull Request set to https://github.com/Normation/ncf/pull/84
Updated by François ARMAND over 10 years ago
- Assignee changed from Vincent MEMBRÉ to François ARMAND
Taking it.
Tested with online regex tester, seems ok.
Updated by Jonathan CLARKE over 10 years ago
- Status changed from Pending technical review to Pending release
- % Done changed from 0 to 100
Applied in changeset commit:85df0e94a26cdb72531b0682521e2adce5fa514e.
Updated by François ARMAND over 10 years ago
Applied in changeset commit:0deb97debc67bd6103f0ab892d10bdc61a3d389f.
Updated by
Updated by Vincent MEMBRÉ about 8 years ago
- Status changed from Pending release to Released
Updated by Alexis Mousset over 2 years ago
- Target version changed from 0.x to ncf-0.x
- Priority set to 0
Updated by Alexis Mousset over 2 years ago
- Project changed from 41 to Rudder
- Category set to Generic methods
Actions