Project

General

Profile

Actions
Copy link

Bug #5243

closed

Error in parsing of bundle names causing ncf to use technique names like "ntp {"

Added by Jonathan CLARKE over 10 years ago. Updated over 2 years ago.

Status:
Released
Priority:
4
Assignee:
François ARMAND
Category:
Generic methods
Target version:
ncf-0.x
Pull Request:
https://github.com/Normation/ncf/pull/84
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
Fix check:
Regression:

Description

This has an impact on the ncf Python lib, the ncf-api and therefore ncf-builder.

The culprit is a badly formed regex in ncf.py:

match = re.match("[^#]*bundle\s+agent\s+([^(]+)\(?([^)]*)\)?.*$", line)

This matches " }" as part of the name.

Subtasks 1 (0 open — 1 closed)

Bug #5245: simplify regexp to parse bundle nameReleasedFrançois ARMANDActions
Actions
Copy link
 #1

Updated by Jonathan CLARKE over 10 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Jonathan CLARKE to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/ncf/pull/84
Actions
Copy link
 #2

Updated by François ARMAND over 10 years ago

  • Assignee changed from Vincent MEMBRÉ to François ARMAND

Taking it.

Tested with online regex tester, seems ok.

Actions
Copy link
 #3

Updated by Jonathan CLARKE over 10 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
Actions
Copy link
 #5

Updated by Benoît PECCATTE over 9 years ago

  • Target version set to 0.x
Actions
Copy link
 #6

Updated by Vincent MEMBRÉ over 8 years ago

  • Status changed from Pending release to Released
Actions
Copy link
 #7

Updated by Alexis Mousset over 2 years ago

  • Target version changed from 0.x to ncf-0.x
  • Priority set to 0
Actions
Copy link
 #8

Updated by Alexis Mousset over 2 years ago

  • Project changed from 41 to Rudder
  • Category set to Generic methods
Actions
Copy link

Also available in: Atom PDF