Project

General

Profile

Actions

Bug #5302

closed

ncf test of "file_enforce_content" fails on CFEngine 3.6.0 but pass on CFEngine 3.5.2

Added by Nicolas PERRON about 8 years ago. Updated 4 months ago.

Status:
Released
Priority:
1
Category:
Generic methods
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Regression:

Description

The add of a new generic_method "file_enforce_content" prevent ncf to be built since the test of "file_enforce_content" does not work on CFEngine 3.6.0. The error messages are:

R: /tmp/ncf/tests/acceptance/./30_generic_methods/file_enforce_content.cf FAIL
R: grep command doesn't return 0 for command: /bin/grep -E "^This is a test line!$" "/tmp/ncf/tests/acceptance/workdir/__30_generic_methods_file_enforce_content_cf/tmp/test_1" 
R: grep command doesn't return 0 for command: /bin/grep -E "^This is a test line!$" "/tmp/ncf/tests/acceptance/workdir/__30_generic_methods_file_enforce_content_cf/tmp/test_2" 

But if it do the same manually:

root@debian-builder-7-64:/tmp/ncf/tests/acceptance# /bin/grep -E '^This is a test line!$' "/tmp/ncf/tests/acceptance/workdir/__30_generic_methods_file_enforce_content_cf/tmp/test_1" 
This is a test line!
root@debian-builder-7-64:/tmp/ncf/tests/acceptance# echo $?
0

Actions #1

Updated by Nicolas PERRON about 8 years ago

  • Status changed from New to Pending technical review
  • Assignee changed from Nicolas PERRON to Nicolas CHARLES
  • % Done changed from 0 to 100
  • Pull Request set to https://github.com/Normation/ncf/pull/91

PR URL added: https://github.com/Normation/ncf/pull/91

Nico, could you review it please ?

Actions #2

Updated by Nicolas PERRON about 8 years ago

  • Status changed from Pending technical review to Pending release

Applied in changeset commit:c72247f2c02ebce3a4107a5b38c976b1dc0199ea.

Actions #3

Updated by Nicolas CHARLES about 8 years ago

Applied in changeset commit:f24ff5a7d73ed09fa73b1d3195d795c134d0e1d2.

Actions #4

Updated by Vincent MEMBRÉ about 6 years ago

  • Status changed from Pending release to Released
Actions #5

Updated by Alexis Mousset 4 months ago

  • Target version changed from 0.x to ncf-0.x
  • Priority set to 0
Actions #6

Updated by Alexis Mousset 4 months ago

  • Project changed from 41 to Rudder
  • Category set to Generic methods
Actions

Also available in: Atom PDF