Project

General

Profile

Actions

Bug #5421

closed

/etc/default/rudder-jetty overwritten on upgrade

Added by Lionel Le Folgoc over 9 years ago. Updated almost 9 years ago.

Status:
Released
Priority:
2
Category:
Scripts
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

Hi,

Rudder 2.11.2 on RHEL6.

/etc/default/rudder-jetty is not marked as config file, so is overwritten on upgrade. This will break the rudderldap component in the distributed architecture, because the following change is lost:

sed -i "s/\(-Dfile.encoding=UTF-8\)/\1\n-Djetty.host=0.0.0.0/" /etc/default/rudder-jetty

I noticed this issue because the inventory submission has been broken since the 2.11.1 -> 2.11.2 upgrade.
Thanks.

Actions #1

Updated by Nicolas CHARLES over 9 years ago

  • Status changed from New to 8
  • Assignee set to Matthieu CERDA
  • Target version set to 2.11.3

Matthieu,

Could you have a look at this one ?

Thank you

Actions #2

Updated by Matthieu CERDA over 9 years ago

  • Project changed from Rudder to 34
  • Status changed from 8 to In progress
  • Priority changed from N/A to 2

Yep !

Actions #3

Updated by Matthieu CERDA over 9 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Matthieu CERDA to Jonathan CLARKE
  • % Done changed from 0 to 100
  • Pull Request set to https://github.com/Normation/rudder-packages/pull/474

PR is ready !

Actions #4

Updated by Jonathan CLARKE over 9 years ago

  • Status changed from Pending technical review to Discussion
  • Assignee changed from Jonathan CLARKE to Matthieu CERDA

As I wrote in the Pull Request Matthieu just proposed:

This file was intentionally left to be overwritten (see #3929). At that point, we decided it was important that we could enforce some basic Jetty settings without them being discarded due to "config file" issues (not being replaced, basically). This is clearly against the idea that /etc/default/* are config files, but if you're using the rudder-jetty package, we assume that it is to use Rudder, and that we should enforce settings in that file to ensure that jetty works with Rudder, like this.

I think that is still the case. But we did introduce a mechanism to add in settings that will be persisted: the /opt/rudder/etc/rudder-jetty.conf config file. Therefore, I don't think we should merge this change to make /etc/default/rudder-jetty a config file, but instead I think that we should change the installation documentation to edit that file instead, and explain all of this in the ticket.

Actions #5

Updated by Matthieu CERDA over 9 years ago

  • Target version changed from 2.11.3 to 2.11.4
Actions #6

Updated by Vincent MEMBRÉ over 9 years ago

  • Target version changed from 2.11.4 to 2.11.5
Actions #7

Updated by Vincent MEMBRÉ over 9 years ago

  • Target version changed from 2.11.5 to 2.11.6
Actions #8

Updated by Lionel Le Folgoc about 9 years ago

Jonathan CLARKE wrote:

I think that is still the case. But we did introduce a mechanism to add in settings that will be persisted: the /opt/rudder/etc/rudder-jetty.conf config file. Therefore, I don't think we should merge this change to make /etc/default/rudder-jetty a config file, but instead I think that we should change the installation documentation to edit that file instead, and explain all of this in the ticket.

Thanks for the explanation. I blindly followed the docs, so I didn't pay attention that I already used /opt/rudder/etc/rudder-jetty.conf to set JAVA_XMX and JAVA_MAXPERMSIZE. Please update your documentation though. :-P

Actions #9

Updated by Matthieu CERDA about 9 years ago

  • Status changed from Discussion to In progress
  • % Done changed from 100 to 80
Actions #10

Updated by Matthieu CERDA about 9 years ago

  • Project changed from 34 to 30
  • Pull Request deleted (https://github.com/Normation/rudder-packages/pull/474)
Actions #11

Updated by Matthieu CERDA about 9 years ago

  • Project changed from 30 to Rudder tools
Actions #12

Updated by Matthieu CERDA about 9 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Matthieu CERDA to Jonathan CLARKE
  • % Done changed from 80 to 100
  • Pull Request set to https://github.com/Normation/rudder-tools/pull/36
Actions #13

Updated by Matthieu CERDA about 9 years ago

  • Assignee changed from Jonathan CLARKE to Benoît PECCATTE
Actions #14

Updated by Matthieu CERDA about 9 years ago

  • Status changed from Pending technical review to Pending release
Actions #16

Updated by Benoît PECCATTE about 9 years ago

  • Category set to Scripts
Actions #17

Updated by Benoît PECCATTE about 9 years ago

  • Target version deleted (2.11.6)
Actions #18

Updated by Benoît PECCATTE almost 9 years ago

  • Status changed from Pending release to Released
  • Target version set to master
Actions

Also available in: Atom PDF