Project

General

Profile

Actions

Bug #5450

closed

ncf method command_execution should contain the command in shell

Added by Jonathan CLARKE over 10 years ago. Updated over 2 years ago.

Status:
Released
Priority:
3
Category:
Generic methods
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
Fix check:
Regression:

Description

The default implementation doesn't use "contain => in_shell", which means if a user enters a command containing a pipe, it will not work. Following POLA, this should "just work"(TM).

Actions #1

Updated by Jonathan CLARKE over 10 years ago

  • Status changed from New to Pending technical review
  • Assignee set to Nicolas CHARLES
  • Pull Request set to https://github.com/Normation/ncf/pull/115
Actions #2

Updated by Jonathan CLARKE over 10 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Applied in changeset commit:02f741e6596a4c50e58c0a7531a220a50dd6e9dd.

Actions #3

Updated by Nicolas CHARLES over 10 years ago

Applied in changeset commit:952547593ef076c26f215931f2477ebc4a92a4fb.

Actions #4

Updated by Benoît PECCATTE over 9 years ago

  • Target version set to 0.x
Actions #5

Updated by Vincent MEMBRÉ over 8 years ago

  • Status changed from Pending release to Released
Actions #6

Updated by Alexis Mousset over 2 years ago

  • Target version changed from 0.x to ncf-0.x
  • Priority set to 0
Actions #7

Updated by Alexis Mousset over 2 years ago

  • Project changed from 41 to Rudder
  • Category set to Generic methods
Actions

Also available in: Atom PDF