Bug #5465
closed
We should not canonify ourselves class context given in ncf
Added by Vincent MEMBRÉ about 10 years ago.
Updated over 2 years ago.
Description
entries in ncf are canonified manualy ( replace \W by _) this replace variable added in by ncf
package_install_${apache.package.name} => package_install__apache_package_name_
We should remove that part, and surround the class by the canonify function:
canonify("package_install_${apache.package.name}");
But we don't want to add a canonify if the class didn't need it
The following class:
suse.debian
should stay lke this
I tried to use canonify, and it failed (at least if we are speaking of the logger_rudder)
You cannot use (anymore?, i think it used before), canonify as an arguement of function; so I cannot use it in the class_noop condition, unless defining an unholy number of variable first with a logical naming scheme (preventing duplicate), and using them in the call to class_noop, and still maintain everything readable.
- Status changed from New to In progress
- Assignee changed from Jonathan CLARKE to Vincent MEMBRÉ
- Target version set to 0.x
- Status changed from In progress to Pending technical review
- Assignee changed from Vincent MEMBRÉ to Benoît PECCATTE
- Pull Request set to https://github.com/Normation/ncf/pull/170
- Status changed from Pending technical review to Discussion
- Assignee changed from Benoît PECCATTE to Vincent MEMBRÉ
- Status changed from Discussion to Pending release
- % Done changed from 0 to 100
Applied in changeset commit:d3565ffb970f594a946eacb196f9446f18b640c6.
Applied in changeset commit:5d4b49118025ea1209281a76e72d6b89a3ed7403.
- Status changed from Pending release to Released
- Target version changed from 0.x to ncf-0.x
- Priority set to 0
- Project changed from 41 to Rudder
- Category set to Generic methods
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by 
Updated by