Project

General

Profile

Actions

Bug #5468

closed

Weird behaviours of partitionMonitoring technique on ZFS on 2.11

Added by Olivier Mauras almost 8 years ago. Updated over 7 years ago.

Status:
Released
Priority:
4
Category:
Techniques
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:

Description

CFEngine 3.6 (so rudder-agent 2.11) outputs useless and silly warnings like this on some partition sizes:

2013-06-20T17:55:32+0000    error: /main/methods/'rabbitmq'/rabbitmq/storage/'/var/lib/rabbitmq': File system '/var/lib/rabbitmq' is suspiciously small! (4116 bytes)

This was reported in CFEngine ticket https://dev.cfengine.com/issues/3016

Following IRC discussion, here's the modification to add, to make it work correctly on ZFS

diff --git a/systemSettings/misc/partitionSizeMonitoring/1.0/monitorPartitionSize.st b/systemSettings/misc/partitionSizeMonitoring/1.0/monitorPartitionSize.st
index 62da9d8..d13a12c 100644
--- a/systemSettings/misc/partitionSizeMonitoring/1.0/monitorPartitionSize.st
+++ b/systemSettings/misc/partitionSizeMonitoring/1.0/monitorPartitionSize.st
@@ -94,5 +94,8 @@ bundle agent monitor_partition_size {

 body volume freespacecheck(threshold) {
     freespace => "$(threshold)";
+    check_foreign  => "false";
+    sensible_size  => "0";
+    sensible_count => "0";
 }
Actions #1

Updated by Nicolas CHARLES almost 8 years ago

  • Status changed from New to In progress
  • Assignee set to Nicolas CHARLES
  • Target version set to 2.11.3

Thank you Olivier !

Actions #2

Updated by Nicolas CHARLES almost 8 years ago

see https://dev.cfengine.com/issues/3016

i target this bug to 2.11 as it has been reported only in 2.11 (could reproduce in 2.10)

Actions #3

Updated by Nicolas CHARLES almost 8 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Nicolas CHARLES to Jonathan CLARKE
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/478
Actions #4

Updated by François ARMAND almost 8 years ago

Nicolas, did you mean "i target this bug to 2.11 as it has been reported only in 2.11 (could NOT reproduce in 2.10)" ? Else, it doesn't make sens to target in 2.11.

Actions #5

Updated by Nicolas CHARLES almost 8 years ago

oh yes, i meant could not reproduce in 2.10
bad case of sloppy finger

Actions #6

Updated by Jonathan CLARKE almost 8 years ago

  • Description updated (diff)

OK, looks good to me (except for some indentation). However the "check_foreign" already defaults to false, so no need to add that.

Actions #7

Updated by Nicolas CHARLES almost 8 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Applied in changeset policy-templates:commit:f7ea7a23584680315d726add4fc40ea80227af5f.

Actions #8

Updated by Nicolas CHARLES almost 8 years ago

Applied in changeset policy-templates:commit:97dbcf29936ec428e00aee896b0a7fafe7e3d81f.

Actions #9

Updated by Vincent MEMBRÉ over 7 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.11.3, which was released on the 25/09/2014.

Actions

Also available in: Atom PDF