Project

General

Profile

Actions

Bug #5558

closed

When we use variables in parameters, for a generic methods that have a condition, the resulting generated not applicable file is invalid

Added by Nicolas CHARLES over 9 years ago. Updated almost 2 years ago.

Status:
Released
Priority:
N/A
Category:
Generic methods
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
Fix check:
Regression:

Description

If I want to use a generic methods, with condition linux, on file name ${env.filename}, then the generated files for report na will use _env_filename as class prefix, which is plain wrong


Subtasks 1 (0 open1 closed)

Bug #5744: missing test in ncfReleasedVincent MEMBRÉActions

Related issues 1 (0 open1 closed)

Related to Rudder - Bug #5465: We should not canonify ourselves class context given in ncfReleasedVincent MEMBRÉActions
Actions #1

Updated by Nicolas CHARLES over 9 years ago

  • Status changed from New to Pending technical review
  • Assignee set to Jonathan CLARKE
  • Pull Request set to https://github.com/Normation/ncf/pull/124/files
Actions #2

Updated by Nicolas CHARLES over 9 years ago

Ha, the logger_rudder should also canonify the class passes in parameter, as class_noop, for the case when we have ${} in them; they are not canonified automagically

Actions #3

Updated by Nicolas CHARLES over 9 years ago

PR has been updated

Actions #4

Updated by Nicolas CHARLES over 9 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Applied in changeset commit:d6dc604f03a7bfa864d8d7f9b4d9894037e02e36.

Actions #5

Updated by Nicolas CHARLES over 9 years ago

Applied in changeset commit:6fa7dcf17c5c30c55dfb108eafdaceb86bdb0425.

Actions #6

Updated by Vincent MEMBRÉ over 7 years ago

  • Status changed from Pending release to Released
Actions #7

Updated by Alexis Mousset almost 2 years ago

  • Target version changed from 0.x to ncf-0.x
  • Priority set to 0
Actions #8

Updated by Alexis Mousset almost 2 years ago

  • Project changed from 41 to Rudder
  • Category set to Generic methods
Actions

Also available in: Atom PDF