Project

General

Profile

Actions

Architecture #5817

closed

Refactor agent type

Added by Vincent MEMBRÉ over 9 years ago. Updated about 6 years ago.

Status:
Rejected
Priority:
2
Category:
Web - Nodes & inventories
Target version:
Effort required:
Name check:
Fix check:
Regression:

Description

Agent type classes are not correct

sealed abstract class AgentType {
  def toString() : String
  def fullname() : String = "CFEngine "+this
  // Tag used in fusion inventory ( > 2.3 )
  lazy val tagValue = s"cfengine-${this}".toLowerCase
  def toRulesPath() : String
}

toString should not be defined like (or with override)
fullname should be a lazy val
toRulesPath should not be in Invetory project, we are not aware here that we should generate rules

Actions #1

Updated by Vincent MEMBRÉ over 9 years ago

  • Tracker changed from Architecture to Bug
  • Project changed from Rudder to 20
  • Category deleted (Architecture - Code maintenance)
Actions #2

Updated by Jonathan CLARKE over 9 years ago

  • Target version changed from 3.0.0~beta1 to 3.0.0~beta2
Actions #3

Updated by François ARMAND over 9 years ago

  • Target version changed from 3.0.0~beta2 to 3.1.0~beta1

Reported in 3.1

Actions #4

Updated by Benoît PECCATTE about 9 years ago

  • Project changed from 20 to Rudder
  • Category set to Web - Nodes & inventories
Actions #5

Updated by Vincent MEMBRÉ almost 9 years ago

  • Target version changed from 3.1.0~beta1 to 3.1.0~rc1
Actions #6

Updated by Vincent MEMBRÉ almost 9 years ago

  • Target version changed from 3.1.0~rc1 to 3.1.0
Actions #7

Updated by Vincent MEMBRÉ over 8 years ago

  • Target version changed from 3.1.0 to 3.1.1
Actions #8

Updated by Vincent MEMBRÉ over 8 years ago

  • Target version changed from 3.1.1 to 3.1.2
Actions #9

Updated by Jonathan CLARKE over 8 years ago

  • Target version changed from 3.1.2 to 3.2.0~beta1
Actions #10

Updated by Vincent MEMBRÉ over 8 years ago

  • Target version changed from 3.2.0~beta1 to 3.2.0~rc1
Actions #11

Updated by Benoît PECCATTE over 8 years ago

  • Target version changed from 3.2.0~rc1 to 3.2.0~rc2
Actions #12

Updated by Benoît PECCATTE about 8 years ago

  • Target version changed from 3.2.0~rc2 to 3.2.0
Actions #13

Updated by Vincent MEMBRÉ about 8 years ago

  • Target version changed from 3.2.0 to 3.2.1
Actions #14

Updated by Vincent MEMBRÉ about 8 years ago

  • Target version changed from 3.2.1 to 3.2.2
Actions #15

Updated by Vincent MEMBRÉ almost 8 years ago

  • Target version changed from 3.2.2 to 3.2.3
Actions #16

Updated by Vincent MEMBRÉ almost 8 years ago

  • Target version changed from 3.2.3 to 3.2.4
Actions #17

Updated by Vincent MEMBRÉ almost 8 years ago

  • Target version changed from 3.2.4 to 3.2.5
Actions #18

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.2.5 to 3.2.6
Actions #19

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.2.6 to 3.2.7
Actions #20

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.2.7 to 3.2.8
Actions #21

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.2.8 to 3.2.9
Actions #22

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.2.9 to 3.2.10
Actions #23

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.2.10 to 3.2.11
Actions #24

Updated by Vincent MEMBRÉ about 7 years ago

  • Target version changed from 3.2.11 to 339
Actions #25

Updated by Vincent MEMBRÉ about 7 years ago

  • Target version changed from 339 to 4.0.4
Actions #26

Updated by Benoît PECCATTE about 7 years ago

  • Tracker changed from Bug to Architecture

Refactor -> architecture

Actions #27

Updated by Vincent MEMBRÉ almost 7 years ago

  • Target version changed from 4.0.4 to 4.0.5
Actions #28

Updated by Vincent MEMBRÉ almost 7 years ago

  • Target version changed from 4.0.5 to 4.0.6
Actions #29

Updated by Vincent MEMBRÉ almost 7 years ago

  • Target version changed from 4.0.6 to 4.0.7
Actions #30

Updated by Vincent MEMBRÉ almost 7 years ago

  • Target version changed from 4.0.7 to 357
Actions #31

Updated by Alexis Mousset over 6 years ago

  • Target version changed from 357 to 4.1.6
Actions #32

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 4.1.6 to 4.1.7
Actions #33

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 4.1.7 to 4.1.8
Actions #34

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 4.1.8 to 4.1.9
Actions #35

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 4.1.9 to 4.1.10
Actions #36

Updated by François ARMAND about 6 years ago

  • Status changed from New to Rejected

It was done in recent (part 4.2, part 4.3) version of Rudder. Closing.

Actions

Also available in: Atom PDF