Actions
Bug #5866
closed
ncf API hooks don't always fail on errors
Status:
Released
Priority:
1 (highest)
Assignee:
Jonathan CLARKE
Category:
Web - Technique editor
Target version:
Pull Request:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:
Description
When we create a new technique with ncf-builder, there may be some errors with the post commit hook, that generates the Technique part
However, error there a never caught, so it silently fails, and create a non usable technique into Rudder.
Updated by Nicolas CHARLES almost 10 years ago
- Status changed from In progress to Pending technical review
- Assignee changed from Nicolas CHARLES to Jonathan CLARKE
- Pull Request set to https://github.com/Normation/rudder-packages/pull/544
Updated by Jonathan CLARKE almost 10 years ago
- Subject changed from Error on Techniques creation may not be reported to ncf API hooks don't always fail on errors
- Status changed from Pending technical review to 8
- Assignee changed from Jonathan CLARKE to Benoît PECCATTE
All the hooks we run from the ncf API should be set -e and report pertinent error messages on failure:
- https://github.com/Normation/rudder-packages/blob/master/rudder-webapp/SOURCES/post.write_technique.commit.sh
- https://github.com/Normation/rudder-packages/blob/master/rudder-webapp/SOURCES/post.write_technique.rudderify.sh
The initial PR presented here is too simple: it only adresses one error case. We should extend this principle.
Updated by Vincent MEMBRÉ almost 10 years ago
- Target version changed from 2.11.5 to 2.11.6
Updated by Benoît PECCATTE almost 10 years ago
- Status changed from 8 to Pending technical review
- Assignee changed from Benoît PECCATTE to Jonathan CLARKE
- Pull Request changed from https://github.com/Normation/rudder-packages/pull/544 to https://github.com/Normation/rudder-packages/pull/567
Updated by Benoît PECCATTE almost 10 years ago
- Status changed from Pending technical review to Pending release
- % Done changed from 0 to 100
Applied in changeset packages:rudder-packages|commit:b70e9879fe5f565d856439159869776c84dfd185.
Updated by Jonathan CLARKE almost 10 years ago
Applied in changeset packages:rudder-packages|commit:c19c64ae14e94848c9f41d87f0b693ffe3ecc20c.
Updated by Vincent MEMBRÉ almost 10 years ago
- Target version changed from 2.11.6 to 2.11.7
Updated by Vincent MEMBRÉ almost 10 years ago
- Status changed from Pending release to Released
This bug has been fixed in Rudder 2.11.7, which was released these days.
- Announcement 2.11
- Changelog 2.11
- Download information: https://www.rudder-project.org/site/get-rudder/downloads/
Actions