Actions
Bug #5872
closedArchitecture #5305: Rewrite techniques so they all use ncf report methods
Missing commas in system techniques cause invalid promises to be generated (3.0 branch)
Pull Request:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:
Description
For example:
/var/rudder/cfengine-community/inputs.new/server-roles/1.0/postgres-check.cf:54:18: error: syntax error ifvarclass => "psql_conf_ok.!psql_conf_updated.!psql_conf_update_error"; ^
This comes from this line:
"any" usebundle => rudder_common_report("server-roles", "result_success", "&TRACKINGKEY&", "Check PostgreSQL configuration", "None", "The SuSE specific postgresql configuration is present") ifvarclass => "psql_conf_ok.!psql_conf_updated.!psql_conf_update_error";
Which is missing a comma (,) after the usebundle attribute, and before the ifvarclass attribute.
There are about 40 such errors, across system techniques. This comes from #5689.
Updated by Jonathan CLARKE about 10 years ago
- Status changed from In progress to Pending technical review
- Assignee changed from Jonathan CLARKE to Nicolas CHARLES
- Pull Request set to https://github.com/Normation/rudder-techniques/pull/580
Updated by Jonathan CLARKE about 10 years ago
- Status changed from Pending technical review to Pending release
- % Done changed from 0 to 100
Applied in changeset policy-templates:commit:72ba7fb78d819461d8d47eb25094f268cc8fa7ec.
Updated by Matthieu CERDA about 10 years ago
Applied in changeset policy-templates:commit:9f4c36db75e5b692a4c51237a18783911ab6f0d2.
Updated by Vincent MEMBRÉ about 10 years ago
- Project changed from Rudder to 24
- Category deleted (
System techniques) - Parent task set to #5305
Updated by Vincent MEMBRÉ about 10 years ago
- Status changed from Pending release to Released
This bug has been fixed in Rudder 3.0.0~beta1 which was release on 01/12/2014.
- Announcement
- Changelog
- "Download information": https://www.rudder-project.org/site/get-rudder/downloads/
Actions