Project

General

Profile

Actions

Bug #5873

closed

User story #5449: Make environment variables accessible as parameter in all Techniques

Non-escaped quotes in environment-variables.cf cause CFEngine parsing error

Added by Jonathan CLARKE about 10 years ago. Updated almost 10 years ago.

Status:
Released
Priority:
2
Category:
Techniques
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

From environment-variables.cf:

    windows::
     "script" string => "@echo off                                                                                                                                                                                                           
for /F  "tokens=1,2* delims==" %%G IN ('SET') DO ECHO =node.env[%%G]=%%H";

This contains double quotes on line 2 that should obviously be escaped.

Actions #1

Updated by Jonathan CLARKE about 10 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Jonathan CLARKE to Nicolas CHARLES
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/581
Actions #2

Updated by Jonathan CLARKE about 10 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Applied in changeset policy-templates:commit:80c8709a45cc986382c076ee301ac27693943cc2.

Actions #3

Updated by Matthieu CERDA about 10 years ago

Applied in changeset policy-templates:commit:8e044da4e197336c56baf13a1db0c1ba7f9841aa.

Actions #4

Updated by Vincent MEMBRÉ about 10 years ago

  • Parent task set to #5449
Actions #5

Updated by Vincent MEMBRÉ about 10 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 3.0.0~beta1 which was release on 01/12/2014.

Actions #6

Updated by Benoît PECCATTE almost 10 years ago

  • Category set to Techniques
Actions

Also available in: Atom PDF