Project

General

Profile

Actions
Copy link

Bug #5884

closed

Architecture #5305: Rewrite techniques so they all use ncf report methods

Architecture #5353: Rewrite reports to use rudder_common_report

Architecture #5689: Rewrite system techniques to use rudder_common_report

Duplicate report introduced in endExecution bundle

Added by Jonathan CLARKE almost 10 years ago. Updated over 9 years ago.

Status:
Released
Priority:
2
Assignee:
Nicolas CHARLES
Category:
Techniques
Target version:
3.0.0~beta1
Pull Request:
https://github.com/Normation/rudder-t...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

As seen in commit:52d4fd20606425cf0403f6b3cea50fe0a5b05296, a duplicate reports line was introduced into promises.st in the endExecution bundle:

   reports:
     start_run_message_sent::
       "@@Common@@log_info@@&TRACKINGKEY&@@common@@EndRun@@${g.execRun}##${g.uuid}@#End execution with config [&RUDDER_NODE_CONFIG_ID&]";

+  reports:
+    cfengine_3::
+      "@@Common@@log_info@@&TRACKINGKEY&@@common@@EndRun@@${g.execRun}##${g.uuid}@#End execution with config [&RUDDER_NODE_CONFIG_ID&]";

This causes trouble in changes-only compliance mode, because the later report is always output. It does, however, no harm in full-compliance mode, since CFEngine considers these 2 promises identical, and only executes it once.

We need to remove the dupe.

Actions
Copy link

Also available in: Atom PDF