Project

General

Profile

Actions
Copy link

Bug #5931

closed

Api does not fail on bad JSON

Bug #5931: Api does not fail on bad JSON

Added by François ARMAND about 11 years ago. Updated almost 8 years ago.

Status:
Released
Priority:
3
Assignee:
François ARMAND
Category:
API
Target version:
4.1.10
Pull Request:
https://github.com/Normation/rudder/p...
Severity:
Minor - inconvenience | misleading | easy workaround
UX impact:
User visibility:
Operational - other Techniques | Technique editor | Rudder settings
Effort required:
Priority:
28
Name check:
Fix check:
Regression:

Description

The Rudder API does not fail when you give it a bad formatted JSON.

The result is that we are thinking it's not a JSON request, and try to parse it as "normal" -d parameters, and don't find anything relevant, so we don't change anything.

This make testing and undertanding API usage extremelly infuriating.

Related issues 1 (0 open — 1 closed)

Related to Rudder - Bug #5786: You cannot pass 'include' / 'exclude' targets as json for Rule API ReleasedVincent MEMBRÉActions

Updated by François ARMAND about 11 years ago Actions
Copy link
 #1

From a technical point of view, we are using lift JsonPost that takes in charge to checking if the parameter is valid json, and is not executed if not.

We should certainly use JsonReq like in http://exploring.liftweb.net/master/index-15.html, and check by ourselve if the JSON is correct.

Updated by Vincent MEMBRÉ about 11 years ago Actions
Copy link
 #2

  • Target version changed from 2.10.8 to 2.10.9

Updated by Vincent MEMBRÉ about 11 years ago Actions
Copy link
 #3

  • Target version changed from 2.10.9 to 2.10.10

Updated by Vincent MEMBRÉ about 11 years ago Actions
Copy link
 #4

  • Target version changed from 2.10.10 to 2.10.11

Updated by Vincent MEMBRÉ almost 11 years ago Actions
Copy link
 #5

  • Target version changed from 2.10.11 to 2.10.12

Updated by Vincent MEMBRÉ almost 11 years ago Actions
Copy link
 #6

  • Target version changed from 2.10.12 to 2.10.13

Updated by Benoît PECCATTE almost 11 years ago Actions
Copy link
 #7

  • Status changed from 8 to New

Updated by Vincent MEMBRÉ almost 11 years ago Actions
Copy link
 #8

  • Target version changed from 2.10.13 to 2.10.14

Updated by Vincent MEMBRÉ over 10 years ago Actions
Copy link
 #9

  • Target version changed from 2.10.14 to 2.10.15

Updated by Vincent MEMBRÉ over 10 years ago Actions
Copy link
 #10

  • Target version changed from 2.10.15 to 2.10.16

Updated by Vincent MEMBRÉ over 10 years ago Actions
Copy link
 #11

  • Target version changed from 2.10.16 to 2.10.17

Updated by Vincent MEMBRÉ over 10 years ago Actions
Copy link
 #12

  • Target version changed from 2.10.17 to 2.10.18

Updated by Vincent MEMBRÉ over 10 years ago Actions
Copy link
 #13

  • Target version changed from 2.10.18 to 2.10.19

Updated by Vincent MEMBRÉ over 10 years ago Actions
Copy link
 #14

  • Target version changed from 2.10.19 to 2.10.20

Updated by Vincent MEMBRÉ about 10 years ago Actions
Copy link
 #15

  • Target version changed from 2.10.20 to 277

Updated by Vincent MEMBRÉ about 10 years ago Actions
Copy link
 #16

  • Target version changed from 277 to 2.11.18

Updated by Vincent MEMBRÉ about 10 years ago Actions
Copy link
 #17

  • Target version changed from 2.11.18 to 2.11.19

Updated by Vincent MEMBRÉ almost 10 years ago Actions
Copy link
 #18

  • Target version changed from 2.11.19 to 2.11.20

Updated by Vincent MEMBRÉ almost 10 years ago Actions
Copy link
 #19

  • Target version changed from 2.11.20 to 2.11.21

Updated by Vincent MEMBRÉ over 9 years ago Actions
Copy link
 #20

  • Target version changed from 2.11.21 to 2.11.22

Updated by Vincent MEMBRÉ over 9 years ago Actions
Copy link
 #21

  • Target version changed from 2.11.22 to 2.11.23

Updated by Vincent MEMBRÉ over 9 years ago Actions
Copy link
 #22

  • Target version changed from 2.11.23 to 2.11.24

Updated by Vincent MEMBRÉ over 9 years ago Actions
Copy link
 #23

  • Target version changed from 2.11.24 to 308

Updated by Vincent MEMBRÉ over 9 years ago Actions
Copy link
 #24

  • Target version changed from 308 to 3.1.14

Updated by Vincent MEMBRÉ over 9 years ago Actions
Copy link
 #25

  • Target version changed from 3.1.14 to 3.1.15

Updated by Vincent MEMBRÉ over 9 years ago Actions
Copy link
 #26

  • Target version changed from 3.1.15 to 3.1.16

Updated by Vincent MEMBRÉ over 9 years ago Actions
Copy link
 #27

  • Target version changed from 3.1.16 to 3.1.17

Updated by Vincent MEMBRÉ about 9 years ago Actions
Copy link
 #28

  • Target version changed from 3.1.17 to 3.1.18

Updated by Vincent MEMBRÉ almost 9 years ago Actions
Copy link
 #29

  • Target version changed from 3.1.18 to 3.1.19

Updated by François ARMAND almost 9 years ago Actions
Copy link
 #30

  • Severity set to Minor - inconvenience | misleading | easy workaround
  • User visibility set to Operational - other Techniques | Technique editor | Rudder settings
  • Priority set to 0

Updated by Vincent MEMBRÉ almost 9 years ago Actions
Copy link
 #31

  • Target version changed from 3.1.19 to 3.1.20

Updated by Vincent MEMBRÉ over 8 years ago Actions
Copy link
 #32

  • Target version changed from 3.1.20 to 3.1.21

Updated by Vincent MEMBRÉ over 8 years ago Actions
Copy link
 #33

  • Target version changed from 3.1.21 to 3.1.22

Updated by Benoît PECCATTE over 8 years ago Actions
Copy link
 #34

  • Priority changed from 0 to 14

Updated by Benoît PECCATTE over 8 years ago Actions
Copy link
 #35

  • Priority changed from 14 to 27

Updated by Vincent MEMBRÉ over 8 years ago Actions
Copy link
 #36

  • Target version changed from 3.1.22 to 3.1.23

Updated by Vincent MEMBRÉ over 8 years ago Actions
Copy link
 #37

  • Target version changed from 3.1.23 to 3.1.24

Updated by Vincent MEMBRÉ over 8 years ago Actions
Copy link
 #38

  • Target version changed from 3.1.24 to 3.1.25

Updated by Vincent MEMBRÉ about 8 years ago Actions
Copy link
 #39

  • Target version changed from 3.1.25 to 387

Updated by Vincent MEMBRÉ about 8 years ago Actions
Copy link
 #40

  • Target version changed from 387 to 4.1.10

Updated by François ARMAND almost 8 years ago Actions
Copy link
 #41

  • Status changed from New to In progress
  • Assignee set to François ARMAND
  • Priority changed from 27 to 28

Updated by François ARMAND almost 8 years ago Actions
Copy link
 #42

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/1856

Updated by Rudder Quality Assistant almost 8 years ago Actions
Copy link
 #43

  • Assignee changed from Vincent MEMBRÉ to François ARMAND

Updated by François ARMAND almost 8 years ago Actions
Copy link
 #44

  • Status changed from Pending technical review to Pending release

Updated by Vincent MEMBRÉ almost 8 years ago Actions
Copy link
 #46

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.1.10 and 4.2.4 which were released today.

Actions
Copy link

Also available in: PDF Atom