Project

General

Profile

Actions

Bug #5937

closed

Enforce the content of the local ncf configuration file from techniques

Added by Nicolas CHARLES over 7 years ago. Updated over 7 years ago.

Status:
Released
Priority:
1
Category:
System techniques
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:

Description

In #5682, we introduced a new format for the ncf configuration file, by using a mustache template

We need to modify the way it is handled by the script rudder-upgrade which sed in it, regardless of the context
We need to obtain, at the end, a config file that owuld look like

{{#classes.any}}
# Which logger(s) should be used in ncf? (comma separated list)
loggers=_logger_default
{{/classes.any}}
# Which port should be for CFEngine connections/data transfers
{{#classes.community_edition}}
cfengine_port=5309
{{/classes.community_edition}}
{{#classes.enterprise_edition}}
cfengine_port=5308
{{/classes.enterprise_edition}}


Related issues 4 (0 open4 closed)

Related to Rudder - Bug #5682: Add a configuration file when using enterprise editionReleasedJonathan CLARKEActions
Related to Rudder - Bug #5980: have the path of the config file overridable ReleasedJonathan CLARKEActions
Related to Rudder - Bug #7452: New version of ncf_conf.cache may not be properly updated on nodes after an upgradeReleasedJonathan CLARKE2015-11-24Actions
Related to Rudder - Bug #7794: rudder-upgrade edits the wrong ncf.conf file causing transitory invalid promises during upgradesReleasedVincent MEMBRÉ2016-01-19Actions
Actions #1

Updated by Nicolas CHARLES over 7 years ago

  • Assignee changed from Matthieu CERDA to Benoît PECCATTE
Actions #2

Updated by Benoît PECCATTE over 7 years ago

  • Status changed from New to Pending technical review
  • Assignee changed from Benoît PECCATTE to Nicolas CHARLES
  • Pull Request set to https://github.com/Normation/rudder-packages/pull/561
Actions #3

Updated by Benoît PECCATTE over 7 years ago

  • Pull Request changed from https://github.com/Normation/rudder-packages/pull/561 to https://github.com/Normation/rudder-packages/pull/562
Actions #4

Updated by Nicolas CHARLES over 7 years ago

  • Project changed from 34 to 24
  • Subject changed from rudder-upgrade seds into ncf.conf to replace all value, but this is not compliant with the new mustache templating for this configuration file to Enforce the content of the ncf configuration file from techniques
  • Category set to Techniques
  • Status changed from Pending technical review to In progress
  • Pull Request deleted (https://github.com/Normation/rudder-packages/pull/562)

The ncf configuration file cannot simply be enforced by packaging, as is it a configuration file of ncf
To avoid any race condition/conflict/issue on ordering, we will enforce its content with the techniques

Actions #5

Updated by Nicolas CHARLES over 7 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Nicolas CHARLES to Benoît PECCATTE
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/610
Actions #6

Updated by Jonathan CLARKE over 7 years ago

Nicolas CHARLES wrote:

The ncf configuration file cannot simply be enforced by packaging, as is it a configuration file of ncf

Well, we should not be changing the ncf version of this config file, only Rudder's instance of it (in /var/rudder/configuration-repository/ncf/).

To avoid any race condition/conflict/issue on ordering, we will enforce its content with the techniques

Sounds good to me.

Actions #7

Updated by Nicolas CHARLES over 7 years ago

  • Subject changed from Enforce the content of the ncf configuration file from techniques to Enforce the content of the local ncf configuration file from techniques
  • Assignee changed from Benoît PECCATTE to Jonathan CLARKE
Actions #8

Updated by Nicolas CHARLES over 7 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Applied in changeset commit:e88ea7d3789e5b8fa5bc2e661407bb2b26a2be88.

Actions #9

Updated by Jonathan CLARKE over 7 years ago

Applied in changeset commit:1962e71d589e799e7514b9844980e5100de5d3aa.

Actions #10

Updated by Vincent MEMBRÉ over 7 years ago

  • Project changed from 24 to Rudder
  • Category changed from Techniques to System techniques
Actions #11

Updated by Vincent MEMBRÉ over 7 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.11.5, which was released today (16/12/14)

Actions #12

Updated by Jonathan CLARKE over 6 years ago

  • Related to Bug #7452: New version of ncf_conf.cache may not be properly updated on nodes after an upgrade added
Actions #13

Updated by Jonathan CLARKE over 6 years ago

  • Related to Bug #7794: rudder-upgrade edits the wrong ncf.conf file causing transitory invalid promises during upgrades added
Actions

Also available in: Atom PDF