Project

General

Profile

Actions

Bug #6080

closed

When using invalid XML character in the technique parameters, the generated matadata.xml is invalid

Added by Nicolas CHARLES over 7 years ago. Updated 4 months ago.

Status:
Released
Priority:
1
Category:
Generic methods
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Regression:

Description

If i create a meta technique with ncf builder, and put a & in it (like, command execution /path/to/command && /bin/true) then the generated xml file is invalid
rudder log shows the following message:

ERROR com.normation.cfclerk.services.impl.GitTechniqueReader - Ignoring technique '/ncf_techniques/Test/1.0/metadata.xml' because the descriptor file is malformed. Error message was: Unexpected issue with the descriptor file /ncf_techniques/Test/1.0/metadata.xml at line 14, column 27: The entity name must immediately follow the '&' in the entity reference.

and Techniques are not reloaded

The generated metadata.xml contains:

<SECTION component="true" multivalued="true" name="Command execution">
      <REPORTKEYS>
        <VALUE>/bin/true && /bin/true</VALUE>
      </REPORTKEYS>
    </SECTION>
  </SECTIONS>

Actions #1

Updated by Nicolas CHARLES over 7 years ago

Using <![CDATA[xxx]]> solves the issue

Actions #2

Updated by Nicolas CHARLES over 7 years ago

  • Status changed from New to Pending technical review
  • Assignee set to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/ncf/pull/165
Actions #3

Updated by Nicolas CHARLES over 7 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Applied in changeset commit:1915fce904c0659520f60dd6d178e1c50d5e2ad8.

Actions #4

Updated by Vincent MEMBRÉ over 7 years ago

Applied in changeset commit:e35f756595400ff8de606ad5007ed32d997439e2.

Actions #5

Updated by Vincent MEMBRÉ about 6 years ago

  • Status changed from Pending release to Released
Actions #6

Updated by Alexis Mousset 4 months ago

  • Target version changed from 0.x to ncf-0.x
  • Priority set to 0
Actions #7

Updated by Alexis Mousset 4 months ago

  • Project changed from 41 to Rudder
  • Category set to Generic methods
Actions

Also available in: Atom PDF