Project

General

Profile

Actions
Copy link

User story #6099

closed

We should be able to call actions as many times as we want

Added by Benoît PECCATTE almost 10 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
N/A
Assignee:
Félix DALLIDET
Category:
Generic methods
Target version:
7.1.0~rc1
Pull Request:
UX impact:
Suggestion strength:
User visibility:
Effort required:
Medium
Name check:
Fix check:
Regression:

Description

Some promises are not state promises but action promises.
Namely service_restart and service_reloas and maby some others are action promises.

Unlike state promises that can be checked and called only once, we should be able to call such promises as many times as we want.
For this purpose, https://dev.cfengine.com/issues/6893 must be solved, and we should use ifelapsed 0 in action promises.

Subtasks 3 (0 open — 3 closed)

Architecture #15783: Make class_prefix uniqueResolvedNicolas CHARLESActions
User story #15784: Base log on the directive id and add a canonified directive id in report_dataReleasedNicolas CHARLESActions
Bug #16078: Applying directives using the exact same GM with same parameters will always result in missing reportsResolvedAlexis MoussetActions

Related issues 2 (0 open — 2 closed)

Related to Rudder - Bug #5991: On a freshly installed node, rsyslog is dropping messagesReleasedBenoît PECCATTE2014-12-12Actions
Related to Rudder - Architecture #6101: We should be able to call ncf generic methods more than onceRejectedActions
Actions
Copy link
 #1

Updated by Alexis Mousset over 8 years ago

  • Category set to Generic methods
Actions
Copy link
 #2

Updated by Alexis Mousset almost 8 years ago

  • Target version changed from 0.x to master
Actions
Copy link
 #3

Updated by Vincent MEMBRÉ about 7 years ago

  • Target version changed from master to 4.2.2
Actions
Copy link
 #4

Updated by Vincent MEMBRÉ about 7 years ago

  • Target version changed from 4.2.2 to 4.2.3
Actions
Copy link
 #5

Updated by Vincent MEMBRÉ almost 7 years ago

  • Target version changed from 4.2.3 to 4.2.4
Actions
Copy link
 #6

Updated by Benoît PECCATTE almost 7 years ago

  • Target version changed from 4.2.4 to Ideas (not version specific)
Actions
Copy link
 #7

Updated by Félix DALLIDET about 5 years ago

  • Target version changed from Ideas (not version specific) to 5.0.14
Actions
Copy link
 #8

Updated by Félix DALLIDET about 5 years ago

  • Status changed from New to In progress
  • Assignee set to Félix DALLIDET
Actions
Copy link
 #9

Updated by Vincent MEMBRÉ about 5 years ago

  • Target version changed from 5.0.14 to 5.0.15
Actions
Copy link
 #11

Updated by Félix DALLIDET about 5 years ago

  • Effort required set to Medium

We should define a dedicated bundle to save the current GM index call:


  methods:
    "Variable string_context_${report_data.directive_id}_0" usebundle => _method_reporting_context("Variable string", "cat");
                                                         ^
                                                         |
                                                current GM index call

This way, we could use this index, concatenated with the directive id to make GM/promiser re-usable by adding comments, ifvarclass, etc...
based on: directive_id_index

In the same fashion suggested in a mix of: 15783 and 16078.
It solves both issues.

Actions
Copy link
 #12

Updated by Vincent MEMBRÉ almost 5 years ago

  • Target version changed from 5.0.15 to 5.0.16
Actions
Copy link
 #13

Updated by Alexis Mousset almost 5 years ago

  • Target version changed from 5.0.16 to 5.0.17
Actions
Copy link
 #14

Updated by Vincent MEMBRÉ over 4 years ago

  • Target version changed from 5.0.17 to 5.0.18
Actions
Copy link
 #15

Updated by Benoît PECCATTE over 4 years ago

  • Target version changed from 5.0.18 to 6.2.0~beta1
Actions
Copy link
 #16

Updated by Vincent MEMBRÉ about 4 years ago

  • Target version changed from 6.2.0~beta1 to 6.2.0~rc1
Actions
Copy link
 #17

Updated by François ARMAND about 4 years ago

  • Target version changed from 6.2.0~rc1 to 7.0.0~beta1
Actions
Copy link
 #18

Updated by Alexis Mousset about 3 years ago

  • Status changed from In progress to New
Actions
Copy link
 #19

Updated by Vincent MEMBRÉ about 3 years ago

  • Target version changed from 7.0.0~beta1 to 7.0.0~beta2
Actions
Copy link
 #20

Updated by Benoît PECCATTE about 3 years ago

  • Project changed from 41 to Rudder
  • Category changed from Generic methods to Generic methods
Actions
Copy link
 #21

Updated by Vincent MEMBRÉ about 3 years ago

  • Target version changed from 7.0.0~beta2 to 7.0.0~beta3
Actions
Copy link
 #22

Updated by Alexis Mousset about 3 years ago

  • Target version changed from 7.0.0~beta3 to 7.1.0~beta1
Actions
Copy link
 #23

Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 7.1.0~beta1 to 7.1.0~beta2
Actions
Copy link
 #24

Updated by Vincent MEMBRÉ over 2 years ago

  • Target version changed from 7.1.0~beta2 to 7.1.0~rc1
Actions
Copy link
 #25

Updated by Alexis Mousset over 2 years ago

done in 7.1!

Actions
Copy link
 #26

Updated by Alexis Mousset over 2 years ago

  • Status changed from New to Resolved
Actions
Copy link

Also available in: Atom PDF