Bug #6205
closed
Compliance computation on home page dashboard charts is incoherent regarding pending nodes
Added by Nicolas CHARLES almost 10 years ago.
Updated over 9 years ago.
Category:
Web - Compliance & node report
Description
I updated my rules on my system, and most of my node are in "pending" state
However, the compliance is "poor", which is disapointing (see screenshot)
Waiting a bit tells me that I do have 100% compliance, which is trye
Files
I see no good way of doing it:
- if we count them as "error" (like now), then we see poor compliance, even if everything is on success afterward
- if we considere "pending" as Success, then we are going to have a lot big fall in compliance when we have errors,
- if we don't count them at all, we will also have variation - but it seems to be the best idea, since in that case, at least, we don't assume a status (be it success or error), and variation will be the smallest.
So I thing we should not count them at all.
- Pull Request set to https://github.com/Normation/rudder/pull/811
There is still a question for the "Nodes by overall compliance".
I think that for that one, we should had a "Applying" case, like in " Global compliance details"
The proposed updated pull request use the following rules, that seems coherent, and at least for me doesn't make me wonder what is happening :
- the "global compliance" dismisses pending nodes ("Applying status"), so that the global compliance reflect a true, known state
- the "global compliance details" does show pending nodes
- the "node by overall compliance" does show the compliance by node, with a new case for pending nodes that are in the same "applying" status than in global compliance details
Other charts are not impacted.
See the snapshot for an overview.
- Subject changed from Inconsistency on home page for compliance to Compliance computation on home page dashboard charts is incoherent regarding pending nodes
- Status changed from Discussion to Pending technical review
- Assignee changed from François ARMAND to Nicolas CHARLES
- Assignee changed from Nicolas CHARLES to Vincent MEMBRÉ
Nicolas seems OK with the logic and the result. Vincent, could you take a look at the PR ?
- Status changed from Pending technical review to Pending release
- % Done changed from 0 to 100
- Status changed from Pending release to Released
This bug has been fixed in Rudder 3.0.0, which was released on 2015/02/16
Also available in: Atom
PDF
Updated by 
Updated by 
