Project

General

Profile

Actions
Copy link

Bug #6343

closed

When a technique reports several time the exact same text, there is only one report generated

Bug #6343: When a technique reports several time the exact same text, there is only one report generated

Added by Nicolas CHARLES over 10 years ago. Updated over 7 years ago.

Status:
Released
Priority:
N/A
Assignee:
Nicolas CHARLES
Category:
System techniques
Target version:
4.1.13
Pull Request:
https://github.com/Normation/rudder-t...
Severity:
Major - prevents use of part of Rudder | no simple workaround
UX impact:
User visibility:
Getting started - demo | first install | level 1 Techniques
Effort required:
Priority:
60
Name check:
Fix check:
Regression:

Description

In the Technique refactoring in Rudder 3.0 to use rudder_common_reports, we introduced a bug which prevent to have duplicate identical reports.

The main problem is that we are calling a bundle to do reports, with exactly the same parameters, and in this bundle, the agent detects that he already handled this promises, and skip it !

This bug appears when in a given directive, we are managing twice (or more) the same object.

A workaround would be to create a new version of rudder_common_report and rudder_common_report_generic, with a new parameter (the current index), and se this index as an handle or comment of the usebundle and reports.
This permit the agent to distinguish each promises.

This should go at least in 3.0, but could go to 2.11 to allow backporting of techniques

Subtasks 7 (0 open — 7 closed)

Bug #6311: Missing reports when editing twice the same file with enforce a file content v7.0ReleasedNicolas CHARLESActions
Bug #6465: Update rudder_common_report and rudder_common_reports_generic to be compatible wiht multi instance techniqueReleasedBenoît PECCATTEActions
Bug #6469: Typo in rudder_common_reports_genericReleasedBenoît PECCATTEActions
Bug #12882: same as parent ticket for branch 4.3ReleasedAlexis MoussetActions
Bug #12941: typo introduced by parent ticket -branch 4.3)ReleasedAlexis MoussetActions
Bug #12889: spurious rudder_common_report_indexs_generic_index introduced by parent ticketReleasedAlexis MoussetActions
Bug #12917: typo introduced by parent ticketReleasedAlexis MoussetActions

Updated by Nicolas CHARLES over 10 years ago Actions
Copy link
 #1

  • Status changed from New to Discussion

Updated by Vincent MEMBRÉ over 10 years ago Actions
Copy link
 #2

  • Target version changed from 2.11.8 to 2.11.9

Updated by Benoît PECCATTE over 10 years ago Actions
Copy link
 #3

We should change Rudder internal API in the following way:

- add a new report bundle that take a new parameter, named or call_id or ...
- call this bundle instead of rudder_common_report in every technique that is multi-instance or can have multivalued components
- use the existing index for multivaluation in the technique as the new parameter
- On old Rudder versions the new bundle should create a report with message containing the index (as nicely as possible)
- On new Rudder versions the new bundle should create a report with a new field containing the index that is parsable by Rudder

Updated by Benoît PECCATTE over 10 years ago Actions
Copy link
 #4

  • Status changed from Discussion to 8
  • Assignee deleted (Benoît PECCATTE)

Updated by Vincent MEMBRÉ over 10 years ago Actions
Copy link
 #5

  • Target version changed from 2.11.9 to 2.11.10

Updated by Nicolas CHARLES over 10 years ago Actions
Copy link
 #6

I checked, and this fix should go in 2.10 as well, there are multininstance technique there using rudder_common_report

Updated by Benoît PECCATTE over 10 years ago Actions
Copy link
 #7

  • Status changed from 8 to New

Updated by Vincent MEMBRÉ over 10 years ago Actions
Copy link
 #8

  • Target version changed from 2.11.10 to 2.11.11

Updated by Vincent MEMBRÉ over 10 years ago Actions
Copy link
 #9

  • Target version changed from 2.11.11 to 2.11.12

Updated by Vincent MEMBRÉ over 10 years ago Actions
Copy link
 #10

  • Target version changed from 2.11.12 to 2.11.13

Updated by Vincent MEMBRÉ over 10 years ago Actions
Copy link
 #11

  • Target version changed from 2.11.13 to 2.11.14

Updated by Vincent MEMBRÉ about 10 years ago Actions
Copy link
 #12

  • Target version changed from 2.11.14 to 2.11.15

Updated by Vincent MEMBRÉ about 10 years ago Actions
Copy link
 #13

  • Target version changed from 2.11.15 to 2.11.16

Updated by Vincent MEMBRÉ about 10 years ago Actions
Copy link
 #14

  • Target version changed from 2.11.16 to 2.11.17

Updated by Vincent MEMBRÉ almost 10 years ago Actions
Copy link
 #15

  • Target version changed from 2.11.17 to 2.11.18

Updated by Vincent MEMBRÉ almost 10 years ago Actions
Copy link
 #16

  • Target version changed from 2.11.18 to 2.11.19

Updated by Vincent MEMBRÉ over 9 years ago Actions
Copy link
 #17

  • Target version changed from 2.11.19 to 2.11.20

Updated by Vincent MEMBRÉ over 9 years ago Actions
Copy link
 #18

  • Target version changed from 2.11.20 to 2.11.21

Updated by Vincent MEMBRÉ over 9 years ago Actions
Copy link
 #19

  • Target version changed from 2.11.21 to 2.11.22

Updated by Vincent MEMBRÉ over 9 years ago Actions
Copy link
 #20

  • Target version changed from 2.11.22 to 2.11.23

Updated by Vincent MEMBRÉ over 9 years ago Actions
Copy link
 #21

  • Target version changed from 2.11.23 to 2.11.24

Updated by Vincent MEMBRÉ about 9 years ago Actions
Copy link
 #22

  • Target version changed from 2.11.24 to 308

Updated by Vincent MEMBRÉ about 9 years ago Actions
Copy link
 #23

  • Target version changed from 308 to 3.1.14

Updated by Vincent MEMBRÉ about 9 years ago Actions
Copy link
 #24

  • Target version changed from 3.1.14 to 3.1.15

Updated by Vincent MEMBRÉ about 9 years ago Actions
Copy link
 #25

  • Target version changed from 3.1.15 to 3.1.16

Updated by Vincent MEMBRÉ about 9 years ago Actions
Copy link
 #26

  • Target version changed from 3.1.16 to 3.1.17

Updated by Vincent MEMBRÉ almost 9 years ago Actions
Copy link
 #27

  • Target version changed from 3.1.17 to 3.1.18

Updated by Vincent MEMBRÉ over 8 years ago Actions
Copy link
 #28

  • Target version changed from 3.1.18 to 3.1.19

Updated by Jonathan CLARKE over 8 years ago Actions
Copy link
 #29

  • Severity set to Major - prevents use of part of Rudder | no simple workaround
  • User visibility set to Getting started - demo | first install | level 1 Techniques

Updated by Benoît PECCATTE over 8 years ago Actions
Copy link
 #30

  • Priority set to 45

Updated by Vincent MEMBRÉ over 8 years ago Actions
Copy link
 #31

  • Target version changed from 3.1.19 to 3.1.20

Updated by Vincent MEMBRÉ over 8 years ago Actions
Copy link
 #32

  • Target version changed from 3.1.20 to 3.1.21

Updated by Vincent MEMBRÉ over 8 years ago Actions
Copy link
 #33

  • Target version changed from 3.1.21 to 3.1.22

Updated by Benoît PECCATTE over 8 years ago Actions
Copy link
 #34

  • Priority changed from 45 to 58

Updated by Vincent MEMBRÉ over 8 years ago Actions
Copy link
 #35

  • Target version changed from 3.1.22 to 3.1.23

Updated by Alexis Mousset about 8 years ago Actions
Copy link
 #36

  • Subject changed from When a Rudder 3.0 Technique reports several time the same the same text, there is only one report generated to When a technique reports several time the exact same text, there is only one report generated

Updated by Alexis Mousset about 8 years ago Actions
Copy link
 #37

rudder_common_report_index allows avoiding this issue. I'm not closing this issue as it is likely not used everywhere.

Updated by Vincent MEMBRÉ about 8 years ago Actions
Copy link
 #38

  • Target version changed from 3.1.23 to 3.1.24

Updated by Vincent MEMBRÉ about 8 years ago Actions
Copy link
 #39

  • Target version changed from 3.1.24 to 3.1.25

Updated by Vincent MEMBRÉ almost 8 years ago Actions
Copy link
 #40

  • Target version changed from 3.1.25 to 387

Updated by Vincent MEMBRÉ almost 8 years ago Actions
Copy link
 #41

  • Target version changed from 387 to 4.1.10

Updated by Vincent MEMBRÉ over 7 years ago Actions
Copy link
 #42

  • Target version changed from 4.1.10 to 4.1.11

Updated by Vincent MEMBRÉ over 7 years ago Actions
Copy link
 #43

  • Target version changed from 4.1.11 to 4.1.12
  • Priority changed from 58 to 59

Updated by Vincent MEMBRÉ over 7 years ago Actions
Copy link
 #44

  • Target version changed from 4.1.12 to 4.1.13

Updated by Vincent MEMBRÉ over 7 years ago Actions
Copy link
 #45

  • Assignee set to Nicolas CHARLES
  • Priority changed from 59 to 60

Updated by Nicolas CHARLES over 7 years ago Actions
Copy link
 #46

  • Status changed from New to In progress

Updated by Nicolas CHARLES over 7 years ago Actions
Copy link
 #47

i'm using this expression to replace 

sed -i "s/\(.*\)rudder_common_report\(.*\)\"),/\1rudder_common_report_index\2\", \"\${index}\"),/"

Updated by Nicolas CHARLES over 7 years ago Actions
Copy link
 #48

  • Status changed from In progress to Pending technical review
  • Assignee changed from Nicolas CHARLES to Alexis Mousset
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/1321

Updated by Rudder Quality Assistant over 7 years ago Actions
Copy link
 #49

  • Assignee changed from Alexis Mousset to Nicolas CHARLES

Updated by Nicolas CHARLES over 7 years ago Actions
Copy link
 #50

  • Status changed from Pending technical review to Pending release

Updated by Vincent MEMBRÉ over 7 years ago Actions
Copy link
 #51

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 4.1.13, 4.2.7 and 4.3.3 which were released today.

Actions
Copy link

Also available in: PDF Atom