Project

General

Profile

Actions

Bug #6460

closed

Architecture #6410: Make ncf api compatible with python 3

Typo in ncf.py, cannot be used

Added by Vincent MEMBRÉ over 7 years ago. Updated 4 months ago.

Status:
Rejected
Priority:
1
Category:
Generic methods
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Regression:

Description

A typo was inserted in tool/ncf.py preventing it usage

line 140:

      if sys.version_info.major == 2:
        unicodeLine = unicode(line,"UTF-8") #line.decode('unicode-escape')
      else
        unicodeLine = line # = str(line, "UTF-8")

The else is missing a colon


Related issues 1 (0 open1 closed)

Related to Rudder - Bug #6440: We can't use é in the generic methods parametersReleasedVincent MEMBRÉActions
Actions #1

Updated by Vincent MEMBRÉ over 7 years ago

  • Status changed from New to In progress
Actions #2

Updated by Vincent MEMBRÉ over 7 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Vincent MEMBRÉ to Benoît PECCATTE
  • Pull Request set to https://github.com/Normation/ncf/pull/185
Actions #3

Updated by Vincent MEMBRÉ over 7 years ago

  • Status changed from Pending technical review to Rejected
  • Assignee changed from Benoît PECCATTE to Vincent MEMBRÉ
  • Pull Request deleted (https://github.com/Normation/ncf/pull/185)

In fact it will be fixed by #6440; rejecting this and making the technical review !

Actions #4

Updated by Vincent MEMBRÉ over 7 years ago

  • Related to Bug #6440: We can't use é in the generic methods parameters added
Actions #5

Updated by Alexis Mousset 4 months ago

  • Target version changed from 0.x to ncf-0.x
  • Priority set to 0
Actions #6

Updated by Alexis Mousset 4 months ago

  • Category set to Generic methods
Actions

Also available in: Atom PDF