Bug #6468
closed
When we install rudder-agent after having removing it, the uuid is not restored on RPM-based systems
Added by Nicolas CHARLES over 9 years ago. Updated over 8 years ago.
Description
After purging rudder-agent, and reinstalling it, the uuid is not restored, which completely defeat the idea of backuping it.
At least on 3.0, but probably in 2.10
Updated by Vincent MEMBRÉ over 9 years ago
- Target version changed from 3.0.4 to 3.0.5
Updated by Vincent MEMBRÉ over 9 years ago
- Target version changed from 3.0.5 to 3.0.6
Updated by Vincent MEMBRÉ over 9 years ago
- Target version changed from 3.0.6 to 3.0.7
Updated by Vincent MEMBRÉ over 9 years ago
- Target version changed from 3.0.7 to 3.0.8
Updated by Vincent MEMBRÉ over 9 years ago
- Target version changed from 3.0.8 to 3.0.9
Updated by Vincent MEMBRÉ about 9 years ago
- Target version changed from 3.0.9 to 3.0.10
Updated by Vincent MEMBRÉ about 9 years ago
- Target version changed from 3.0.10 to 3.0.11
Updated by Vincent MEMBRÉ about 9 years ago
- Target version changed from 3.0.11 to 3.0.12
Updated by Vincent MEMBRÉ almost 9 years ago
- Target version changed from 3.0.12 to 3.0.13
Updated by Vincent MEMBRÉ almost 9 years ago
- Target version changed from 3.0.13 to 3.0.14
Updated by Vincent MEMBRÉ over 8 years ago
- Target version changed from 3.0.14 to 3.0.15
Updated by Vincent MEMBRÉ over 8 years ago
- Target version changed from 3.0.15 to 3.0.16
Updated by Jonathan CLARKE over 8 years ago
- Subject changed from When we install rudder-agent after having purged it, the uuid is not restored to When we install rudder-agent after having removing it, the uuid is not restored
Nicolas CHARLES wrote:
After purging rudder-agent, and reinstalling it, the uuid is not restored, which completely defeat the idea of backuping it.
At least on 3.0, but probably in 2.10
There is a vocabulary confusion here: if we are purging a package (apt-get purge), then this is the expected behaviour.
If we did not, but we just removed the package, then this file should indeed be restored. According to #7901 this works.
It needs testing again to confirm.
Updated by Jonathan CLARKE over 8 years ago
- Related to Bug #7901: Backup and restore policy_server.dat like we do with uuid.hive file added
Updated by Jonathan CLARKE over 8 years ago
- Assignee changed from Matthieu CERDA to François ARMAND
Updated by François ARMAND over 8 years ago
- Translation missing: en.field_tag_list set to Next minor release
- Assignee changed from François ARMAND to Benoît PECCATTE
- Target version changed from 3.0.16 to 2.11.21
- How to reproduce updated (diff)
Validated: with a simple remove / install, the uuid is not restored on centos6/7.
The behaviour is consistent on debian: apt-get remove / install => uuid.hive restored ; apt-get purge / install => new uuid.hive.
Updated by François ARMAND over 8 years ago
- Priority changed from N/A to 2
This is not a big problem, but it is a non-consistence between package, so a maintenance nightmare in the future (so the next minor).
Updated by Jonathan CLARKE over 8 years ago
- Subject changed from When we install rudder-agent after having removing it, the uuid is not restored to When we install rudder-agent after having removing it, the uuid is not restored on RPM-based systems
- In RPM packages, the postinst will always generate a new UUID, see https://github.com/Normation/rudder-packages/blob/branches/rudder/3.1/rudder-agent/SPECS/rudder-agent.spec#L538
- In deb package, the postinst never generates a new UUID, it just runs check-rudder-agent to do that job, and that script will restore a backup if there is one available and only generate a new UUID if not. See https://github.com/Normation/rudder-packages/blob/branches/rudder/3.1/rudder-agent/debian/postinst#L173
However, in master (future 3.3/4.0), this behaviour has been harmonised and all platforms use the approach currently in RPM packages. This actually duplicates the code from check-rudder-agent.
I believe the correct solution here is therefore to follow the deb package approach, and always call check-rudder-agent at the end of postinst to restore existing UUID or create a new one if necessary.
Updated by Jonathan CLARKE over 8 years ago
- Status changed from New to In progress
- Assignee changed from Benoît PECCATTE to Jonathan CLARKE
Updated by Jonathan CLARKE over 8 years ago
- Status changed from In progress to Pending technical review
- Assignee changed from Jonathan CLARKE to Benoît PECCATTE
- Pull Request set to https://github.com/Normation/rudder-packages/pull/912
Updated by Jonathan CLARKE over 8 years ago
- Status changed from Pending technical review to Pending release
- % Done changed from 0 to 100
Applied in changeset rudder-packages|32730ec7ffd20a5692d3280218d4f6c4d73bf519.
Updated by Vincent MEMBRÉ over 8 years ago
- Status changed from Pending release to Released
This bug has been fixed in Rudder 2.11.21, 3.0.16, 3.1.10 and 3.2.3 which were released on 2016-06-01, but not announced.
- 2.11: Changelog
- 3.0: Changelog
- 3.1: Changelog
- 3.2: Changelog
- Download: https://www.rudder-project.org/site/get-rudder/downloads/