Project

General

Profile

Actions

Bug #6573

closed

Bug #6534: Displaying the technique list in ncf-builder can take more than one minute

check_output function has no env param

Added by Vincent MEMBRÉ over 7 years ago. Updated 4 months ago.

Status:
Released
Priority:
1
Category:
Generic methods
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Regression:

Description

in #6534, we passed an environment variable to cf-promises to reduce network attempt when computing techniques metadata

But this is passed as param of check_output function, which only accept one param

setting the function to check_output(command, env = dict()) fix this issue

Actions #1

Updated by Vincent MEMBRÉ over 7 years ago

  • Status changed from New to In progress
Actions #2

Updated by Vincent MEMBRÉ over 7 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Vincent MEMBRÉ to Benoît PECCATTE
  • Pull Request set to https://github.com/Normation/ncf/pull/197
Actions #3

Updated by Vincent MEMBRÉ over 7 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Applied in changeset commit:6c19ad9e8fcb29eff2e7ce17613566c54c101ef2.

Actions #4

Updated by Benoît PECCATTE over 7 years ago

Applied in changeset commit:a85eea72b3f49785087f40a0582d0077cc88665d.

Actions #5

Updated by Vincent MEMBRÉ about 6 years ago

  • Status changed from Pending release to Released
Actions #6

Updated by Alexis Mousset 4 months ago

  • Target version changed from 0.x to ncf-0.x
  • Priority set to 0
Actions #7

Updated by Alexis Mousset 4 months ago

  • Project changed from 41 to Rudder
  • Category set to Generic methods
Actions

Also available in: Atom PDF