Project

General

Profile

Actions

User story #6639

closed

Add shared-files to .gitignore

Added by Benoît PECCATTE almost 9 years ago. Updated over 8 years ago.

Status:
Rejected
Priority:
N/A
Category:
System integration
Target version:
UX impact:
Suggestion strength:
User visibility:
Effort required:
Name check:
Fix check:
Regression:

Description

shared-file is a directory in configuration-repository, but it should generally be ignored.
We should add it to .gitignore.


Related issues 1 (0 open1 closed)

Related to Rudder - User story #7167: Put ncf/ncf_hash_file in .gitignoreReleasedBenoît PECCATTE2015-11-26Actions
Actions #1

Updated by Benoît PECCATTE almost 9 years ago

  • Subject changed from Add shared-files to .gitingnore to Add shared-files to .gitignore
Actions #2

Updated by Matthieu CERDA almost 9 years ago

I do agree.

Actions #3

Updated by Matthieu CERDA almost 9 years ago

  • Assignee set to Matthieu CERDA
Actions #4

Updated by Matthieu CERDA over 8 years ago

  • Assignee changed from Matthieu CERDA to Benoît PECCATTE

Reassigning to BPE

Actions #5

Updated by Jonathan CLARKE over 8 years ago

Actions #6

Updated by Jonathan CLARKE over 8 years ago

  • Target version changed from Ideas (not version specific) to 3.2.0~beta1
Actions #7

Updated by Jonathan CLARKE over 8 years ago

  • Status changed from New to In progress
  • Assignee changed from Benoît PECCATTE to Jonathan CLARKE
Actions #8

Updated by Jonathan CLARKE over 8 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Jonathan CLARKE to Benoît PECCATTE
  • Pull Request set to https://github.com/Normation/rudder-packages/pull/816
Actions #9

Updated by Vincent MEMBRÉ over 8 years ago

Are we sure we want this ?

I think it's cool to use the git on shared to:

  • Have an history of changes on their shared configuration file
  • Share them using git to other rudder ( dev => prod )
Actions #10

Updated by Jonathan CLARKE over 8 years ago

  • Status changed from Pending technical review to Rejected

Vincent MEMBRÉ wrote:

Are we sure we want this ?

I think it's cool to use the git on shared to:

  • Have an history of changes on their shared configuration file
  • Share them using git to other rudder ( dev => prod )

Oh, you're absolutely right, Vincent - we need these files in shared-files for using git to share configs. Rejecting this issue.

Actions

Also available in: Atom PDF