Bug #6648: "Update" component of common technique sometimes return unexpected status and has incomplete reporting - Rudder - Issue Tracker

Actions

Copy link

Bug #6648

closed

"Update" component of common technique sometimes return unexpected status and has incomplete reporting

Added by François ARMAND over 9 years ago. Updated about 9 years ago.

Status:

Released

Priority:

Assignee:

Benoît PECCATTE

Category:

System techniques

Target version:

2.10.20

Pull Request:

https://github.com/Normation/rudder-t...

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

That's not every time, the result looks like: http://www.screencast.com/t/wqBQzMNL

The unexpected is on the update component.

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Vincent MEMBRÉ over 9 years ago

Target version changed from 3.0.6 to 3.0.7

Actions

Copy link

Updated by Alexis Mousset over 9 years ago

I saw this too.

Logs:

R: @@Common@@log_repaired@@hasPolicyServer-root@@common-root@@1@@Update@@None@@2015-07-07 13:48:48+00:00##root@#Rudder ncf local instance updated
R: @@Common@@result_repaired@@hasPolicyServer-root@@common-root@@1@@Update@@None@@2015-07-07 13:48:48+00:00##root@#Rudder policy, tools or ncf instance were updated or CFEngine service restarted
R: @@Common@@result_success@@hasPolicyServer-root@@common-root@@1@@Update@@None@@2015-07-07 13:48:48+00:00##root@#Rudder policy server doesn't need to be updated

The problem is that the success reporting is always sent:

policy_server::
  "any" usebundle => rudder_common_report("Common", "result_success", "&TRACKINGKEY&", "Update", "None", "Rudder policy server doesn't need to be updated");

Actions

Copy link

Updated by Vincent MEMBRÉ over 9 years ago

Target version changed from 3.0.7 to 3.0.8

Actions

Copy link

Updated by Alexis Mousset over 9 years ago

Target version changed from 3.0.8 to 2.10.16

Actions

Copy link

Updated by Alexis Mousset over 9 years ago

Status changed from New to In progress
Assignee set to Alexis Mousset

Actions

Copy link

Updated by Alexis Mousset over 9 years ago

Status changed from In progress to Discussion
Assignee deleted (~~Alexis Mousset~~)

I don't get why there is a special case for policy_server.

Actions

Copy link

Updated by Alexis Mousset over 9 years ago

Assignee set to Nicolas CHARLES

Nicolas, do you know if there is a reason ?

Actions

Copy link

Updated by Vincent MEMBRÉ over 9 years ago

Target version changed from 2.10.16 to 2.10.17

Actions

Copy link

Updated by Vincent MEMBRÉ about 9 years ago

Target version changed from 2.10.17 to 2.10.18

Actions

Copy link

#10

Updated by Vincent MEMBRÉ about 9 years ago

Target version changed from 2.10.18 to 2.10.19

Actions

Copy link

#11

Updated by Maxime Longuet about 9 years ago

I've always this bug on 3.1.3 ;)

Actions

Copy link

#12

Updated by Vincent MEMBRÉ about 9 years ago

Target version changed from 2.10.19 to 2.10.20

Actions

Copy link

#13

Updated by Jonathan CLARKE about 9 years ago

Alexis MOUSSET wrote:

I don't get why there is a special case for policy_server.

There shouldn't be. None of the promises above have a "policy_server" condition, so reporting shouldn't either.

I'm on it.

Actions

Copy link

#14

Updated by Jonathan CLARKE about 9 years ago

Status changed from Discussion to In progress
Assignee changed from Nicolas CHARLES to Jonathan CLARKE

Actions

Copy link

#15

Updated by Jonathan CLARKE about 9 years ago

Related to Bug #2755: The server node doesn't seems to send some reports: common/update, common/log system for reports distributePolicy added

Actions

Copy link

#16

Updated by Jonathan CLARKE about 9 years ago

Subject changed from Common technique sometimes return unexpected status to "Update" component of common technique sometimes return unexpected status and has incomplete reporting

There are several issues with reporting in this Technique:

Any policy_servers just announce result_success, regardless of actual status. This doesn't matter if an error occured (errors take precedence) but causes the unexpected status if another real result_success is sent, or just a result_repaired.
The rudder_tools_updated_error class is never considered in reporting, therefore sometimes errors can be missed.
The condition leading to report result_success is only partially correct, which can lead to some false positive reports (reporting success when it should be repaired)

Actions

Copy link

#17

Updated by Jonathan CLARKE about 9 years ago

Status changed from In progress to Pending technical review
Assignee changed from Jonathan CLARKE to Benoît PECCATTE
Pull Request set to https://github.com/Normation/rudder-techniques/pull/784

PR https://github.com/Normation/rudder-techniques/pull/784

Actions

Copy link

#18