Project

General

Profile

Bug #6648

"Update" component of common technique sometimes return unexpected status and has incomplete reporting

Added by François ARMAND almost 6 years ago. Updated about 5 years ago.

Status:
Released
Priority:
4
Category:
System techniques
Target version:
Severity:
User visibility:
Effort required:
Priority:

Description

That's not every time, the result looks like: http://www.screencast.com/t/wqBQzMNL

The unexpected is on the update component.


Related issues

Related to Rudder - Bug #2755: The server node doesn't seems to send some reports: common/update, common/log system for reports distributePolicyReleasedNicolas PERRON2012-08-02Actions
#1

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 3.0.6 to 3.0.7
#2

Updated by Alexis MOUSSET over 5 years ago

I saw this too.

Logs:

R: @@Common@@log_repaired@@hasPolicyServer-root@@common-root@@1@@Update@@None@@2015-07-07 13:48:48+00:00##root@#Rudder ncf local instance updated
R: @@Common@@result_repaired@@hasPolicyServer-root@@common-root@@1@@Update@@None@@2015-07-07 13:48:48+00:00##root@#Rudder policy, tools or ncf instance were updated or CFEngine service restarted
R: @@Common@@result_success@@hasPolicyServer-root@@common-root@@1@@Update@@None@@2015-07-07 13:48:48+00:00##root@#Rudder policy server doesn't need to be updated

The problem is that the success reporting is always sent:

policy_server::
  "any" usebundle => rudder_common_report("Common", "result_success", "&TRACKINGKEY&", "Update", "None", "Rudder policy server doesn't need to be updated");

#3

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 3.0.7 to 3.0.8
#4

Updated by Alexis MOUSSET over 5 years ago

  • Target version changed from 3.0.8 to 2.10.16
#5

Updated by Alexis MOUSSET over 5 years ago

  • Status changed from New to In progress
  • Assignee set to Alexis MOUSSET
#6

Updated by Alexis MOUSSET over 5 years ago

  • Status changed from In progress to Discussion
  • Assignee deleted (Alexis MOUSSET)

I don't get why there is a special case for policy_server.

#7

Updated by Alexis MOUSSET over 5 years ago

  • Assignee set to Nicolas CHARLES

Nicolas, do you know if there is a reason ?

#8

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 2.10.16 to 2.10.17
#9

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 2.10.17 to 2.10.18
#10

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 2.10.18 to 2.10.19
#11

Updated by Maxime Longuet over 5 years ago

I've always this bug on 3.1.3 ;)

#12

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 2.10.19 to 2.10.20
#13

Updated by Jonathan CLARKE over 5 years ago

Alexis MOUSSET wrote:

I don't get why there is a special case for policy_server.

There shouldn't be. None of the promises above have a "policy_server" condition, so reporting shouldn't either.

I'm on it.

#14

Updated by Jonathan CLARKE over 5 years ago

  • Status changed from Discussion to In progress
  • Assignee changed from Nicolas CHARLES to Jonathan CLARKE
#15

Updated by Jonathan CLARKE over 5 years ago

  • Related to Bug #2755: The server node doesn't seems to send some reports: common/update, common/log system for reports distributePolicy added
#16

Updated by Jonathan CLARKE over 5 years ago

  • Subject changed from Common technique sometimes return unexpected status to "Update" component of common technique sometimes return unexpected status and has incomplete reporting

There are several issues with reporting in this Technique:

  • Any policy_servers just announce result_success, regardless of actual status. This doesn't matter if an error occured (errors take precedence) but causes the unexpected status if another real result_success is sent, or just a result_repaired.
  • The rudder_tools_updated_error class is never considered in reporting, therefore sometimes errors can be missed.
  • The condition leading to report result_success is only partially correct, which can lead to some false positive reports (reporting success when it should be repaired)
#17

Updated by Jonathan CLARKE over 5 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Jonathan CLARKE to Benoît PECCATTE
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/784
#18

Updated by Jonathan CLARKE over 5 years ago

  • Assignee changed from Benoît PECCATTE to Nicolas CHARLES
#19

Updated by Jonathan CLARKE over 5 years ago

  • Assignee changed from Nicolas CHARLES to Benoît PECCATTE
#20

Updated by Jonathan CLARKE over 5 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
#22

Updated by Vincent MEMBRÉ about 5 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.10.20, 2.11.17, 3.0.12 and 3.1.5 which were released today.

Also available in: Atom PDF