Project

General

Profile

Actions

Bug #7100

closed

Launching twice in a row a disabled agent make the agent runs

Added by Nicolas CHARLES over 9 years ago. Updated over 8 years ago.

Status:
Released
Priority:
1 (highest)
Category:
System techniques
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

If /opt/rudder/etc/disable-agent is set, the agent is supposed to suicide itself
However, locking can get in the way, and if cf-agent is launch twice in a row, the first run locks the promise that check for the file, and the second run will hapilly ignore this file....


Subtasks 1 (0 open1 closed)

Bug #8434: Syntaxt error in promise.stReleasedNicolas CHARLES2016-06-01Actions
Actions #1

Updated by Vincent MEMBRÉ about 9 years ago

  • Target version changed from 2.10.17 to 2.10.18
Actions #2

Updated by Vincent MEMBRÉ about 9 years ago

  • Target version changed from 2.10.18 to 2.10.19
Actions #3

Updated by Vincent MEMBRÉ about 9 years ago

  • Target version changed from 2.10.19 to 2.10.20
Actions #4

Updated by Vincent MEMBRÉ almost 9 years ago

  • Target version changed from 2.10.20 to 277
Actions #5

Updated by Vincent MEMBRÉ almost 9 years ago

  • Target version changed from 277 to 2.11.18
Actions #6

Updated by Vincent MEMBRÉ almost 9 years ago

  • Target version changed from 2.11.18 to 2.11.19
Actions #7

Updated by Alexis Mousset almost 9 years ago

The Rudder cli CFEngine wrapper added in 3.1 and 3.2 checks this file before calling CFEngine (to be able to display a clear error message, and avoid a fatal error), and this issue cannot happen.

Still valid for 2.11 and 3.0.

Actions #8

Updated by Vincent MEMBRÉ over 8 years ago

  • Target version changed from 2.11.19 to 2.11.20
Actions #9

Updated by Vincent MEMBRÉ over 8 years ago

  • Target version changed from 2.11.20 to 2.11.21
Actions #10

Updated by Jonathan CLARKE over 8 years ago

  • Status changed from New to In progress
  • Assignee set to Jonathan CLARKE
Actions #11

Updated by Jonathan CLARKE over 8 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Jonathan CLARKE to Nicolas CHARLES
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/940
Actions #12

Updated by Vincent MEMBRÉ over 8 years ago

  • Target version changed from 2.11.21 to 2.11.22
Actions #13

Updated by Jonathan CLARKE over 8 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
Actions #14

Updated by Vincent MEMBRÉ over 8 years ago

  • Subject changed from When the file /opt/rudder/etc/disable-agent is set, running twice in a row cf-agent (without any prameters) override the disabling to Launching twice in a row a disabled agent make the agent runs
Actions #15

Updated by Vincent MEMBRÉ over 8 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.11.22, 3.0.17, 3.1.11 and 3.2.4 which were released today.

Actions

Also available in: Atom PDF