Rudder

The Background for the request: We are having a very extensive Nagios-Monitoring set up, that is checking all our systems over SSH, and is executing local tests, and according to that, creates notification, that is hooked into a ticketing system, and according to the host the notification is originating to, the appropriate support group is determined...

• monitor server-A if you would check for server-B's inventory;
• somehow parse the inventory to get the info of which node's inventory you are actually checking for;
• have some kind of inotify set up, as the agent's run forwards the inventory and removes if afterwards;

There is currently a file being updated when the policy is fetched from the policy server, we'd be happy to have a similar file when the inventory upload has been executed successfully (I don't think the effort in touching a file on a successful upload would be that hard or break anything, as it's a new file).

Proposed patchset:

# diff -u8 /var/rudder/cfengine-community/inputs/inventory/1.0/fusionAgent.cf{.orig,}
--- /var/rudder/cfengine-community/inputs/inventory/1.0/fusionAgent.cf.orig     2015-10-05 16:54:38.000000000 +0200
+++ /var/rudder/cfengine-community/inputs/inventory/1.0/fusionAgent.cf  2015-10-05 17:02:17.000000000 +0200
@@ -442,16 +442,21 @@
     !windows.inventory_sent.!cant_send_inventory::
       "${g.rudder_inventories}" 
         transformer  => "${g.rudder_rm} -f ${this.promiser}",
         depth_search => recurse_visible(1),
         file_select  => inventory_files,
         classes      => if_else("inventory_file_deleted", "cant_delete_inventory_file"),
         comment      => "Cleaning up inventory files already sent to the server";

+      "${g.rudder_base}/etc/inventory_uploaded" 
+       create       => "true",
+       touch        => "true",
+       comment      => "Create local info about successful upload";
+
       "${g.rudder_var_tmp}/inventory" 
         transformer  => "${g.rudder_rm} -f ${this.promiser}",
         depth_search => recurse_visible(1),
         file_select  => inventory_files,
         classes      => if_else("inventory_file_deleted", "cant_delete_inventory_file"),
         comment      => "Cleaning up inventory files already sent to the server";

   reports:

Test looks OK:

node:~ # ll /opt/rudder/etc/inventory_uploaded
-rw------- 1 root root 0 Oct  5 17:01 /opt/rudder/etc/inventory_uploaded
node:~ # rudder agent inventory > /dev/null
node:~ # ll /opt/rudder/etc/inventory_uploaded
-rw------- 1 root root 0 Oct  5 17:04 /opt/rudder/etc/inventory_uploaded
node:~ #

Janos, there is indeed something that is touched when an inventory is sent, it's the inventory directory.

If the last inventory has failed to be sent, this directory contains the inventory file.
Otherwise, the modification time of this directory is the last successful inventory time.

Is this enough for you or do you still need a specific file to be touched ?

Well, the problem is if I'd like to check for a valid inventory sent, I'd have to check the dir's timestamp and also if there are any files within.
That would be a lot of error-prone than just having to check the modification time of a dedicated file.
As the classes are already defined and used, the change would be minor (however, probably not what I googled together on cf-engine syntax...).
I would be happy if that additional file-touching could be implemented...

OK, we just need to define the right place to put the timestamp file.
It doesn't really belong to etc/
I'd prefer to use something like /opt/rudder/var/fusioninventory or something under /var/rudder/tmp/

Related to #7282

Applied in changeset rudder-techniques|b4d4d6ea9b58175fcc478b250671388fbd12879d.