Project

General

Profile

Bug #7222

Allow disable of git-autocommit of system policy on Update

Added by Janos Mattyasovszky over 4 years ago. Updated almost 4 years ago.

Status:
Released
Priority:
2
Category:
Server components
Target version:
Severity:
User visibility:
Effort required:
Priority:

Description

Hi,

When updating, the rudder-update script auto-commits the new set of system policies, which is nice...
But when one has modifications on the system policy, we'd like to have a possibility to review the changes before it is commited and a technique-reload is triggered.

We propose checking an environment-variable, that would disable this auto-commit feature and warn the user to review the changes manually.

found in: Update from 2.11.11 -> 2.11.13


Related issues

Related to Rudder - Bug #10001: Allow to restrict edits on sudoers during installReleased2017-01-13Actions

Associated revisions

Revision 9d179fb1 (diff)
Added by Janos Mattyasovszky over 4 years ago

Fixes #7222: Allow technique auto-commit disable

When an update is done, and one has customized some system techniques,
the automatic git commit and technique library reload may not be wanted.

This commit allows to specify an environment variable during an update
to disable this automated commit and warns the user to do that manually.

Revision 00c0f994
Added by Benoît PECCATTE about 4 years ago

Merge pull request #763 from matya/patch-7222-disable-autocommit-of-system-policy

Fixes #7222: Allow technique auto-commit disable

History

#1

Updated by Janos Mattyasovszky over 4 years ago

  • Pull Request set to https://github.com/matya/rudder-packages/pull/1
#2

Updated by Matthieu CERDA over 4 years ago

  • Status changed from New to Pending technical review
  • Assignee set to François ARMAND
  • Priority changed from N/A to 2
  • Target version set to 2.11.15

Thanks for the PR Janos !!!

Giving to FAR for TR dispatch.

#3

Updated by Janos Mattyasovszky over 4 years ago

Well, the technique library update could also be moved into the if-then-else's if part...\

Please use https://github.com/matya/rudder-packages/pull/2

#4

Updated by Janos Mattyasovszky over 4 years ago

  • Pull Request changed from https://github.com/matya/rudder-packages/pull/1 to https://github.com/matya/rudder-packages/pull/2
#5

Updated by Janos Mattyasovszky over 4 years ago

  • Pull Request changed from https://github.com/matya/rudder-packages/pull/2 to https://github.com/Normation/rudder-packages/pull/763

Fixed PR to be based on Normation's repo

#6

Updated by Vincent MEMBRÉ over 4 years ago

  • Target version changed from 2.11.15 to 2.11.16
#7

Updated by Vincent MEMBRÉ over 4 years ago

  • Target version changed from 2.11.16 to 2.11.17
#8

Updated by François ARMAND over 4 years ago

  • Assignee changed from François ARMAND to Benoît PECCATTE

Sorry, I missed that one. Benoit, could you put an eye on it ?

#9

Updated by Vincent MEMBRÉ about 4 years ago

  • Target version changed from 2.11.17 to 2.11.18
#10

Updated by Vincent MEMBRÉ about 4 years ago

  • Target version changed from 2.11.18 to 2.11.19
#11

Updated by Janos Mattyasovszky about 4 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
#12

Updated by Vincent MEMBRÉ almost 4 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.11.19, 3.0.14, 3.1.8 and 3.2.1 which were released today.

#13

Updated by Janos Mattyasovszky about 3 years ago

  • Related to Bug #10001: Allow to restrict edits on sudoers during install added

Also available in: Atom PDF