Project

General

Profile

Actions

Bug #7222

closed

Allow disable of git-autocommit of system policy on Update

Added by Janos Mattyasovszky over 5 years ago. Updated about 5 years ago.

Status:
Released
Priority:
2
Category:
Server components
Target version:
Severity:
User visibility:
Effort required:
Priority:

Description

Hi,

When updating, the rudder-update script auto-commits the new set of system policies, which is nice...
But when one has modifications on the system policy, we'd like to have a possibility to review the changes before it is commited and a technique-reload is triggered.

We propose checking an environment-variable, that would disable this auto-commit feature and warn the user to review the changes manually.

found in: Update from 2.11.11 -> 2.11.13


Related issues

Related to Rudder - Bug #10001: Allow to restrict edits on sudoers during installReleased2017-01-13Actions
Actions #1

Updated by Janos Mattyasovszky over 5 years ago

  • Pull Request set to https://github.com/matya/rudder-packages/pull/1
Actions #2

Updated by Matthieu CERDA over 5 years ago

  • Status changed from New to Pending technical review
  • Assignee set to François ARMAND
  • Priority changed from N/A to 2
  • Target version set to 2.11.15

Thanks for the PR Janos !!!

Giving to FAR for TR dispatch.

Actions #3

Updated by Janos Mattyasovszky over 5 years ago

Well, the technique library update could also be moved into the if-then-else's if part...\

Please use https://github.com/matya/rudder-packages/pull/2

Actions #4

Updated by Janos Mattyasovszky over 5 years ago

  • Pull Request changed from https://github.com/matya/rudder-packages/pull/1 to https://github.com/matya/rudder-packages/pull/2
Actions #5

Updated by Janos Mattyasovszky over 5 years ago

  • Pull Request changed from https://github.com/matya/rudder-packages/pull/2 to https://github.com/Normation/rudder-packages/pull/763

Fixed PR to be based on Normation's repo

Actions #6

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 2.11.15 to 2.11.16
Actions #7

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 2.11.16 to 2.11.17
Actions #8

Updated by François ARMAND over 5 years ago

  • Assignee changed from François ARMAND to Benoît PECCATTE

Sorry, I missed that one. Benoit, could you put an eye on it ?

Actions #9

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 2.11.17 to 2.11.18
Actions #10

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 2.11.18 to 2.11.19
Actions #11

Updated by Janos Mattyasovszky about 5 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
Actions #12

Updated by Vincent MEMBRÉ about 5 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.11.19, 3.0.14, 3.1.8 and 3.2.1 which were released today.

Actions #13

Updated by Janos Mattyasovszky over 4 years ago

  • Related to Bug #10001: Allow to restrict edits on sudoers during install added
Actions

Also available in: Atom PDF