Project

General

Profile

Actions

Bug #7226

closed

service_ensure_started_at_boot does not work on non-systemd systems with upsteam CFEngine stdlib

Added by Tomas Corej about 7 years ago. Updated 4 months ago.

Status:
Released
Priority:
N/A
Category:
Generic methods
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Regression:

Description

It does not work because there is typo in variable name:

"command_to_register" string => "${paths.path[update_rcd]} ${service_name} defaults";

but paths.path[update_rcd] does not exists, paths.path[update_rc_d] does . There is also same error in linux knowledge bundle so class update_rcd_utility_present is never evaluated .

Actions #1

Updated by Tomas Corej about 7 years ago

Now I see that paths.path[update_rcd] is in cfengine library that is distributed with ncf. I've used original cfengine std lib from masterfiles. But it seems that this typo is in ncf stdlib as well.

Actions #2

Updated by Jonathan CLARKE almost 7 years ago

  • Subject changed from service_ensure_started_at_boot does not work on non-systemd systems to service_ensure_started_at_boot does not work on non-systemd systems with upsteam CFEngine stdlib
  • Target version set to 0.x

Thanks for this bug report, Tomas. You're right, something fishy has obviously happened with this key in paths. However, it works OK with ncf's copy of the stdlib, so I've clarified the subject.

Actions #3

Updated by Jonathan CLARKE almost 7 years ago

  • Status changed from New to In progress
  • Assignee set to Jonathan CLARKE
Actions #4

Updated by Jonathan CLARKE almost 7 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Jonathan CLARKE to Benoît PECCATTE
  • Pull Request set to https://github.com/Normation/ncf/pull/279
Actions #5

Updated by Jonathan CLARKE almost 7 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Applied in changeset commit:b8cc2ef38ac41fcbe7816aa9fa8e27b3b4d7bd6a.

Actions #6

Updated by Nicolas CHARLES almost 7 years ago

Applied in changeset commit:1c1f83f1d242bda3426e558c2642f04d940e45cb.

Actions #7

Updated by Vincent MEMBRÉ about 6 years ago

  • Status changed from Pending release to Released
Actions #8

Updated by Alexis Mousset 4 months ago

  • Target version changed from 0.x to ncf-0.x
  • Priority set to 0
Actions #9

Updated by Alexis Mousset 4 months ago

  • Project changed from 41 to Rudder
  • Category set to Generic methods
Actions

Also available in: Atom PDF