Bug #7286: Link from node/directive list to node detail is broken on Firefox - Rudder - Issue Tracker

Actions

Copy link

Bug #7286

closed

Link from node/directive list to node detail is broken on Firefox

Added by Nicolas CHARLES about 9 years ago. Updated about 9 years ago.

Status:

Released

Priority:

N/A

Assignee:

Vincent MEMBRÉ

Category:

Web - Nodes & inventories

Target version:

2.10.19

Pull Request:

https://github.com/Normation/rudder/p...

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

On latest version of Chromium/Firefox, when we click on the loop on the node list, we arrive to the searchNode page with the correct URL, however, the node detail is not loaded
Breaks on Firefox 44, Chromium 46

It works perfectly on Chromium 45, Forefox 31 (and some version in between 44 and 31, needs further testing)

Subtasks 1 (0 open — 1 closed)

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Nicolas CHARLES about 9 years ago

The parsing of the nodeId is made by

JSON.parse(window.location.hash.substring(1));
SyntaxError: JSON.parse: expected property name or '}' at line 1 column 2 of the JSON data

JSON.parse(window.location.hash.substring(1));

which fails

window.location.hash.substring(1);
"{%22nodeId%22:%220c846655-cb06-486f-ace4-eaeb11372097%22}"

Actions

Copy link

Updated by Nicolas CHARLES about 9 years ago

https://bugzilla.mozilla.org/show_bug.cgi?id=1184589

could also impact Safari

Actions

Copy link

Updated by Nicolas CHARLES about 9 years ago

JSON.parse(decodeURI(window.location.hash.split("#")[1]));

seems to fix the issue on firefox

Actions

Copy link

Updated by Nicolas CHARLES about 9 years ago

Subject changed from Link from node list to node detail is broken on Firefox to Link from node/directive list to node detail is broken on Firefox

this also happen for the directives link!

Actions

Copy link

Updated by Nicolas CHARLES about 9 years ago

Subject changed from Link from node/directive list to node detail is broken on Firefox to Link from node/directive list to node detail is broken on Firefox (branch 2.10)

Actions

Copy link

Updated by Nicolas CHARLES about 9 years ago

Status changed from New to Pending technical review
Pull Request set to https://github.com/Normation/rudder/pull/930/files

https://github.com/Normation/rudder/pull/930/files

Actions

Copy link

Updated by Nicolas CHARLES about 9 years ago

Related to Bug #7287: Link from node/directive list to node detail is broken on Firefox (branch 3.0) added

Actions

Copy link

Updated by Nicolas CHARLES about 9 years ago

Status changed from Pending technical review to Pending release
% Done changed from 0 to 100

Applied in changeset rudder|892f1dc8ef5221de80eebbac2a67eb8eed6e2c0a.

Actions

Copy link

Updated by Vincent MEMBRÉ about 9 years ago

Applied in changeset rudder|a183c041f16f2f24a977c134103a8d324236b648.

Actions

Copy link

#10

Updated by Nicolas CHARLES about 9 years ago

Description updated (diff)

Actions

Copy link

#11

Updated by Vincent MEMBRÉ about 9 years ago

Subject changed from Link from node/directive list to node detail is broken on Firefox (branch 2.10) to Link from node/directive list to node detail is broken on Firefox

Actions

Copy link

#12