https://issues.rudder.io/https://issues.rudder.io/themes/rudder7/favicon/favicon.ico?17096450182015-11-13T16:14:04ZIssue TrackerRudder - User story #7402: Add a <FILE> tag in metadata.xml to allow simple file copy into techniqueshttps://issues.rudder.io/issues/7402?journal_id=478022015-11-13T16:14:04ZVincent MEMBRÉvme@rudder.io
<ul></ul><p>Should OUTPTAH follow the same logic as TML ? (nothing specified put the file in techniqueName directory) ?</p> Rudder - User story #7402: Add a <FILE> tag in metadata.xml to allow simple file copy into techniqueshttps://issues.rudder.io/issues/7402?journal_id=478032015-11-13T16:16:36ZVincent MEMBRÉvme@rudder.io
<ul></ul><p>My bad I thought there was an OUTPATH in TML</p> Rudder - User story #7402: Add a <FILE> tag in metadata.xml to allow simple file copy into techniqueshttps://issues.rudder.io/issues/7402?journal_id=478062015-11-13T16:29:25ZFrançois ARMANDfrancois.armand@rudder.io
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/47806/diff?detail_id=59352">diff</a>)</li></ul> Rudder - User story #7402: Add a <FILE> tag in metadata.xml to allow simple file copy into techniqueshttps://issues.rudder.io/issues/7402?journal_id=478172015-11-13T16:55:50ZVincent MEMBRÉvme@rudder.io
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-16 priority-default closed parent" href="/issues/7377">User story #7377</a>: Adapt rudderify script to use <FILE> in the generated metadata.xml</i> added</li></ul> Rudder - User story #7402: Add a <FILE> tag in metadata.xml to allow simple file copy into techniqueshttps://issues.rudder.io/issues/7402?journal_id=478452015-11-16T12:11:06ZFrançois ARMANDfrancois.armand@rudder.io
<ul></ul><p>Here, we have a decision to take: either files in <FILES> are "tracked" by Rudder (or part of Rudder internal boudaries) or not.</p>
<p>So, what does I mean here? I mean does updating a file is observed by Rudder (and MUST be observed, always), or does such a file is external and can't be observed (or even if it can, it is not mandatory). (this comment is also linled to <a class="external" href="http://www.rudder-project.org/redmine/issues/7376#note-5">http://www.rudder-project.org/redmine/issues/7376#note-5</a>)</p>
<p>The main practical difference is about who is responsible to see that the file changed and that every node copy of the file should be updated. If the file is external, Rudder can't do it (not always, at least), and if internal, it MUST do it.</p>
<p>My analysis is that as long as the file copy is part of the promise generation process, it must be internal, and basically it is a part of what defined the technique and must follows the same requirement as a template. <br />If so, it's quite easy to know how the file is in Rudder system boundaries: it's commited in our configuration-repository. And an update is always observable via a git diff.</p>
<p>Of course, there is drawbacks: for one, files must be in the git, with all implied by tha (binaries are going to waste space in the repo, user must git add/git commit, etc).</p>
<p>Note that is would be mandatory for a "API" kind of resource, if such one existed, to be external (and so, it must be the nodes which have the update logic of such a resource).</p>
<p>What do you think ?</p> Rudder - User story #7402: Add a <FILE> tag in metadata.xml to allow simple file copy into techniqueshttps://issues.rudder.io/issues/7402?journal_id=478462015-11-16T12:34:57ZFrançois ARMANDfrancois.armand@rudder.io
<ul></ul><p>François ARMAND wrote:</p>
<blockquote>
<p>If so, it's quite easy to know how the file is in Rudder system boundaries: it's commited in our configuration-repository. And an update is always observable via a git diff.</p>
</blockquote>
<p>This part can be relaxed and we can just look at the last know file modification time to observe an update. That take care of the binaries problem, but on the other hand give us less control about what changed. That can be what is expected by a user.</p>
<p>An other point: it can be very suprising for an user to have a file versionned on git, but to use the file content available on the FS and not on the last commit. I'm thinking at that especially for ncf techniques, which are expected to use the <FILE> tag, are commited on "configuration-repository" git, but that content won't be used. <br />On the other hand, if we have a different for file under coniguration-repository than on other parts of the FS, it's complete madness. So that would mean to tags, one for "file in git", and other for "file in fs"... Which is barelly clearer...</p>
<p>So, not sure about what is the best.</p> Rudder - User story #7402: Add a <FILE> tag in metadata.xml to allow simple file copy into techniqueshttps://issues.rudder.io/issues/7402?journal_id=478512015-11-16T16:05:28ZFrançois ARMANDfrancois.armand@rudder.io
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/47851/diff?detail_id=59416">diff</a>)</li></ul><p>So, we choose to only authorise file in git configuration-repository for now. Big binary files should be avoid and use the share-files folder for now. In the future, we may had an other tag to handle FS-based files.</p> Rudder - User story #7402: Add a <FILE> tag in metadata.xml to allow simple file copy into techniqueshttps://issues.rudder.io/issues/7402?journal_id=478522015-11-16T16:09:25ZFrançois ARMANDfrancois.armand@rudder.io
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/47852/diff?detail_id=59417">diff</a>)</li></ul> Rudder - User story #7402: Add a <FILE> tag in metadata.xml to allow simple file copy into techniqueshttps://issues.rudder.io/issues/7402?journal_id=478902015-11-17T22:44:21ZFrançois ARMANDfrancois.armand@rudder.io
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-7 priority-lowest closed parent" href="/issues/7376">User story #7376</a>: Authorize both path relative to technique and to config-repos in technique metadata.xml descriptor</i> added</li></ul> Rudder - User story #7402: Add a <FILE> tag in metadata.xml to allow simple file copy into techniqueshttps://issues.rudder.io/issues/7402?journal_id=479042015-11-19T17:02:03ZFrançois ARMANDfrancois.armand@rudder.io
<ul><li><strong>Status</strong> changed from <i>In progress</i> to <i>Pending technical review</i></li><li><strong>Assignee</strong> changed from <i>François ARMAND</i> to <i>Nicolas CHARLES</i></li><li><strong>Pull Request</strong> set to <i>https://github.com/Normation/rudder/pull/967</i></li></ul><p>PR <a class="external" href="https://github.com/Normation/rudder/pull/967">https://github.com/Normation/rudder/pull/967</a></p> Rudder - User story #7402: Add a <FILE> tag in metadata.xml to allow simple file copy into techniqueshttps://issues.rudder.io/issues/7402?journal_id=479182015-11-20T11:31:07ZFrançois ARMANDfrancois.armand@rudder.io
<ul><li><strong>Status</strong> changed from <i>Pending technical review</i> to <i>Pending release</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Applied in changeset <a class="changeset" title="Fixes #7402: Add a <FILE> tag in metadata.xml to allow simple file copy into techniques" href="https://issues.rudder.io/projects/rudder/repository/rudder/revisions/685db1239d74ffe7ef5928c9f931b83fafcea3e4">rudder|685db1239d74ffe7ef5928c9f931b83fafcea3e4</a>.</p> Rudder - User story #7402: Add a <FILE> tag in metadata.xml to allow simple file copy into techniqueshttps://issues.rudder.io/issues/7402?journal_id=479192015-11-20T11:31:10ZNicolas CHARLESnicolas.charles@rudder.io
<ul></ul><p>Applied in changeset <a class="changeset" title="Merge pull request #967 from fanf/ust_7402/add_a_file_tag_in_metadata_xml_to_allow_simple_file_co..." href="https://issues.rudder.io/projects/rudder/repository/rudder/revisions/c90a092e0db88d410ac04bfba1c80076ce1a8447">rudder|c90a092e0db88d410ac04bfba1c80076ce1a8447</a>.</p> Rudder - User story #7402: Add a <FILE> tag in metadata.xml to allow simple file copy into techniqueshttps://issues.rudder.io/issues/7402?journal_id=479402015-11-22T14:09:18ZNicolas CHARLESnicolas.charles@rudder.io
<ul></ul><p>we are missing an option to add it in the input list, so files are not taken into account</p> Rudder - User story #7402: Add a <FILE> tag in metadata.xml to allow simple file copy into techniqueshttps://issues.rudder.io/issues/7402?journal_id=479982015-11-23T17:01:35ZBenoît PECCATTEbenoit.peccatte@rudder.io
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-16 priority-default closed parent" href="/issues/7432">User story #7432</a>: Don't copy files of local/50_techniques on the nodes</i> added</li></ul> Rudder - User story #7402: Add a <FILE> tag in metadata.xml to allow simple file copy into techniqueshttps://issues.rudder.io/issues/7402?journal_id=487842015-12-07T14:00:46ZJonathan CLARKEjonathan.clarke@normation.com
<ul></ul><p>Documented in <a class="external" href="http://www.rudder-project.org/foswiki/Development/TechniqueXML">http://www.rudder-project.org/foswiki/Development/TechniqueXML</a></p> Rudder - User story #7402: Add a <FILE> tag in metadata.xml to allow simple file copy into techniqueshttps://issues.rudder.io/issues/7402?journal_id=490642015-12-09T15:51:32ZVincent MEMBRÉvme@rudder.io
<ul><li><strong>Status</strong> changed from <i>Pending release</i> to <i>Released</i></li></ul><p>This bug has been fixed in Rudder 3.2.0~beta1 which was released today. </p>
<ul>
<li>3.2: <a href="http://www.rudder-project.org/pipermail/rudder-announce/2015-December/000169.html" class="external">Announce</a> <a href="http://www.rudder-project.org/foswiki/bin/view/System/Documentation:ChangeLog32" class="external">Changelog</a></li>
<li>Download: <a class="external" href="https://www.rudder-project.org/site/get-rudder/downloads/">https://www.rudder-project.org/site/get-rudder/downloads/</a></li>
</ul>