Project

General

Profile

Actions

Bug #7461

closed

classes_* methods should refuse to copy classes to a prefix which is an empty string

Added by Jonathan CLARKE almost 7 years ago. Updated 4 months ago.

Status:
Released
Priority:
N/A
Category:
Generic methods
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Regression:

Description

Currently, classes_* methods copy classes to any destination prefix you give them, even if it's an empty string. They should have sanity checks to avoid settings dangerous classes like "_repaired".


Subtasks 1 (0 open1 closed)

Bug #7463: classes_* methods should refuse to copy classes to a prefix which is an empty string (master branch)ReleasedBenoît PECCATTEActions

Related issues 1 (0 open1 closed)

Related to Rudder - Bug #7459: Reporting is broken for several ncf generic methods because the new class_prefix is not computed without this.callers_promisers, and any conditions using class_prefix are incorrectly evaluatedReleasedBenoît PECCATTEActions
Actions #1

Updated by Jonathan CLARKE almost 7 years ago

  • Related to Bug #7459: Reporting is broken for several ncf generic methods because the new class_prefix is not computed without this.callers_promisers, and any conditions using class_prefix are incorrectly evaluated added
Actions #2

Updated by Jonathan CLARKE almost 7 years ago

  • Status changed from New to In progress
  • Assignee set to Jonathan CLARKE
Actions #3

Updated by Jonathan CLARKE almost 7 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Jonathan CLARKE to Benoît PECCATTE
  • Pull Request set to https://github.com/Normation/ncf/pull/272
Actions #4

Updated by Jonathan CLARKE almost 7 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Applied in changeset commit:db3c3d0aa54077256d322664055e9b2f1e6229fd.

Actions #5

Updated by Benoît PECCATTE almost 7 years ago

Applied in changeset commit:285c09c362f37517820b209cd2b6e62c111968b5.

Actions #6

Updated by Vincent MEMBRÉ about 6 years ago

  • Status changed from Pending release to Released
Actions #7

Updated by Alexis Mousset 4 months ago

  • Target version changed from 0.x to ncf-0.x
  • Priority set to 0
Actions #8

Updated by Alexis Mousset 4 months ago

  • Project changed from 41 to Rudder
  • Category set to Generic methods
Actions

Also available in: Atom PDF