User story #7490: Make the agent resend the inventory if sending failed - Rudder - Issue Tracker

Actions

Copy link

User story #7490

closed

Make the agent resend the inventory if sending failed

Added by Nicolas CHARLES almost 9 years ago. Updated over 6 years ago.

Status:

Released

Priority:

N/A

Assignee:

Benoît PECCATTE

Category:

System techniques

Target version:

4.1.13

Pull Request:

https://github.com/Normation/rudder-t...

UX impact:

Suggestion strength:

User visibility:

Getting started - demo | first install | level 1 Techniques

Effort required:

Name check:

Fix check:

Regression:

Description

On first runs, the webdav is not correctly configured on the rudder server root, so the promises will configure the webdav password, and restart apache, and the root server will send its inventory to the webdav, that may be not yet configured, or restarting.
So there is a slight possibility that it fails, and keep an incomplete inventory of the server (with file staying in /var/rudder/inventory), and there is also a possibility that the initial promises never had a chance to quick in to send the inventory to the default apache endpoint

To be on the safe side, the root server should always send its inventory to the endpoint

This won't be done in the initial promises (as the web interface may not be configured when we are in intial promises), but really in normal operation (so when promises have been generated)

Actions

Copy link

Updated by Nicolas CHARLES almost 9 years ago

Status changed from New to In progress

Actions

Copy link

Updated by Vincent MEMBRÉ almost 9 years ago

Target version changed from 3.2.0~beta1 to 3.2.0~rc1

Actions

Copy link

Updated by Benoît PECCATTE almost 9 years ago

Target version changed from 3.2.0~rc1 to 3.2.0~rc2

Actions

Copy link

Updated by Benoît PECCATTE almost 9 years ago

Target version changed from 3.2.0~rc2 to 3.2.0

Actions

Copy link

Updated by Vincent MEMBRÉ almost 9 years ago

Target version changed from 3.2.0 to 3.2.1

Actions

Copy link

Updated by Vincent MEMBRÉ over 8 years ago

Target version changed from 3.2.1 to 3.2.2

Actions

Copy link

Updated by Vincent MEMBRÉ over 8 years ago

Target version changed from 3.2.2 to 3.2.3

Actions

Copy link

Updated by Vincent MEMBRÉ over 8 years ago

Target version changed from 3.2.3 to 3.2.4

Actions

Copy link

Updated by Vincent MEMBRÉ over 8 years ago

Target version changed from 3.2.4 to 3.2.5

Actions

Copy link

#10

Updated by Vincent MEMBRÉ over 8 years ago

Target version changed from 3.2.5 to 3.2.6

Actions

Copy link

#11

Updated by Vincent MEMBRÉ about 8 years ago

Target version changed from 3.2.6 to 3.2.7

Actions

Copy link

#12

Updated by Vincent MEMBRÉ about 8 years ago

Target version changed from 3.2.7 to 3.2.8

Actions

Copy link

#13

Updated by Vincent MEMBRÉ about 8 years ago

Target version changed from 3.2.8 to 3.2.9

Actions

Copy link

#14

Updated by Vincent MEMBRÉ about 8 years ago

Target version changed from 3.2.9 to 3.2.10

Actions

Copy link

#15

Updated by Nicolas CHARLES about 8 years ago

Status changed from In progress to New

Actions

Copy link

#16

Updated by Vincent MEMBRÉ almost 8 years ago

Target version changed from 3.2.10 to 3.2.11

Actions

Copy link

#17

Updated by Vincent MEMBRÉ almost 8 years ago

Target version changed from 3.2.11 to 339

Actions

Copy link

#18

Updated by Vincent MEMBRÉ almost 8 years ago

Target version changed from 339 to 4.0.4

Actions

Copy link

#19

Updated by Jonathan CLARKE over 7 years ago

Severity set to Minor - inconvenience | misleading | easy workaround
User visibility set to Getting started - demo | first install | level 1 Techniques

Sending directly to the endpoint from promises is not a good idea, because if the endpoint is overloaded it will simply return an error (as designed) but promises don't have any retry mechanism to handle this (which is why this bug is a problem in the first place).

We could and probably should add a retry mechanism to send failed inventories in promises.

Also I don't think we should bypass the webdav to send inventories. Everything is much easier when there are no exceptions, and all inventories are processed in the same way. We have plans to use apache hooks to add actions when inventories are received for example.

Actions

Copy link

#20

Updated by Benoît PECCATTE over 7 years ago

Priority set to 29

Actions

Copy link

#21

Updated by Vincent MEMBRÉ over 7 years ago

Target version changed from 4.0.4 to 4.0.5

Actions

Copy link

#22

Updated by Jonathan CLARKE over 7 years ago

Assignee deleted (~~Nicolas CHARLES~~)

Actions

Copy link

#23

Updated by Vincent MEMBRÉ over 7 years ago

Target version changed from 4.0.5 to 4.0.6

Actions

Copy link

#24

Updated by Vincent MEMBRÉ over 7 years ago

Target version changed from 4.0.6 to 4.0.7

Actions

Copy link

#25

Updated by Vincent MEMBRÉ over 7 years ago

Target version changed from 4.0.7 to 357

Actions

Copy link

#26

Updated by Benoît PECCATTE over 7 years ago

Priority changed from 29 to 42

Actions

Copy link

#27

Updated by Alexis Mousset over 7 years ago

Target version changed from 357 to 4.1.6

Actions

Copy link

#28

Updated by Vincent MEMBRÉ over 7 years ago

Target version changed from 4.1.6 to 4.1.7

Actions

Copy link

#29

Updated by Vincent MEMBRÉ about 7 years ago

Target version changed from 4.1.7 to 4.1.8

Actions

Copy link

#30

Updated by Vincent MEMBRÉ about 7 years ago

Target version changed from 4.1.8 to 4.1.9

Actions

Copy link

#31

Updated by Vincent MEMBRÉ almost 7 years ago

Target version changed from 4.1.9 to 4.1.10

Actions

Copy link

#32

Updated by Benoît PECCATTE almost 7 years ago

I don't see the inconvenience, if the inventory is not sent, the server still works, and the inventory will be sent again the day after.

Actions

Copy link

#33

Updated by Nicolas CHARLES almost 7 years ago

Benoît PECCATTE wrote:

I don't see the inconvenience, if the inventory is not sent, the server still works, and the inventory will be sent again the day after.

It shows in the interface "No machine inventory", which is not great for a first contact with Rudder

Actions

Copy link

#34

Updated by Benoît PECCATTE almost 7 years ago

Wouldn't it be the right to implement inventory resend in case of error ?

Actions

Copy link

#35

Updated by Nicolas CHARLES almost 7 years ago

Yes, but here the case can be vicious: inventory is send, received, and then the webapp can be restarted before it's fully parsed.

Actions

Copy link

#36

Updated by Benoît PECCATTE almost 7 years ago

Does the webapp return an OK code before processing inventories ?

Actions

Copy link

#37

Updated by Benoît PECCATTE almost 7 years ago

In fact we would send to webdav, so this case would be handled by send-clean

Actions

Copy link

#38

Updated by Benoît PECCATTE almost 7 years ago

Status changed from New to In progress
Assignee set to Benoît PECCATTE

Actions

Copy link

#39

Updated by Benoît PECCATTE almost 7 years ago

Tracker changed from Bug to User story
Subject changed from root server sends inventory to itself via the webdav rather than the endpoint, which can fail because of race condition to Make the agent resend the inventory if sending failed

Actions

Copy link

#40

Updated by Benoît PECCATTE almost 7 years ago

Status changed from In progress to Pending technical review
Assignee changed from Benoît PECCATTE to Nicolas CHARLES
Pull Request set to https://github.com/Normation/rudder-techniques/pull/1250

PR https://github.com/Normation/rudder-techniques/pull/1250

Actions

Copy link

#41