https://issues.rudder.io/https://issues.rudder.io/themes/rudder7/favicon/favicon.ico?17096450182015-11-30T12:02:21ZIssue TrackerRudder - Bug #7508: The rudder-agent cron on AIX uses if then, which makes some security test failshttps://issues.rudder.io/issues/7508?journal_id=484382015-11-30T12:02:21ZJonathan CLARKEjonathan.clarke@normation.com
<ul></ul><p>What is the cron line that triggers these test failures?</p> Rudder - Bug #7508: The rudder-agent cron on AIX uses if then, which makes some security test failshttps://issues.rudder.io/issues/7508?journal_id=484392015-11-30T12:05:02ZNicolas CHARLESnicolas.charles@rudder.io
<ul></ul><p>the only one set on AIX<br /><pre>
if [ -x /opt/rudder/bin/check-rudder-agent ]; then /opt/rudder/bin/check-rudder-agent >/dev/null; fi
</pre></p> Rudder - Bug #7508: The rudder-agent cron on AIX uses if then, which makes some security test failshttps://issues.rudder.io/issues/7508?journal_id=484542015-11-30T15:22:25ZBenoît PECCATTEbenoit.peccatte@rudder.io
<ul></ul><p>Does it test && ? <br />We can use this line instead<br />[ -x /opt/rudder/bin/check-rudder-agent ] && /opt/rudder/bin/check-rudder-agent >/dev/null</p> Rudder - Bug #7508: The rudder-agent cron on AIX uses if then, which makes some security test failshttps://issues.rudder.io/issues/7508?journal_id=484722015-11-30T16:22:34ZNicolas CHARLESnicolas.charles@rudder.io
<ul></ul><p>Unfortunately, this does not work<br /><pre>
0,5,10,15,20,25,30,35,40,45,50,55 * * * * [ -x /opt/rudder/bin/check-rudder-agent ] && /opt/rudder/bin/check-rudder-agent >/dev/null
Detailed debug from aixpert:
***** AIX MACHINE : Nov 30 17:09:47 ******
rootcrnjobck.sh: Cronjob [ do not have a binary/script associated with it
</pre></p> Rudder - Bug #7508: The rudder-agent cron on AIX uses if then, which makes some security test failshttps://issues.rudder.io/issues/7508?journal_id=484732015-11-30T16:23:26ZJonathan CLARKEjonathan.clarke@normation.com
<ul></ul><p>Well, the whole test if the file exists is a bit superfluous. We could just run the script, no?</p> Rudder - Bug #7508: The rudder-agent cron on AIX uses if then, which makes some security test failshttps://issues.rudder.io/issues/7508?journal_id=484762015-11-30T16:35:20ZNicolas CHARLESnicolas.charles@rudder.io
<ul></ul><p>Jonathan CLARKE wrote:</p>
<blockquote>
<p>Well, the whole test if the file exists is a bit superfluous. We could just run the script, no?</p>
</blockquote>
<p>I do agree, but if we really want to keep it, we can use</p>
<pre>
test -x /opt/rudder/bin/check-rudder-agent && /opt/rudder/bin/check-rudder-agent
</pre><br />as it passes the tests Rudder - Bug #7508: The rudder-agent cron on AIX uses if then, which makes some security test failshttps://issues.rudder.io/issues/7508?journal_id=484772015-11-30T17:39:03ZJonathan CLARKEjonathan.clarke@normation.com
<ul><li><strong>Target version</strong> changed from <i>3.2.0~beta1</i> to <i>2.10.20</i></li></ul> Rudder - Bug #7508: The rudder-agent cron on AIX uses if then, which makes some security test failshttps://issues.rudder.io/issues/7508?journal_id=484782015-11-30T17:39:16ZJonathan CLARKEjonathan.clarke@normation.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In progress</i></li><li><strong>Assignee</strong> set to <i>Jonathan CLARKE</i></li></ul> Rudder - Bug #7508: The rudder-agent cron on AIX uses if then, which makes some security test failshttps://issues.rudder.io/issues/7508?journal_id=484792015-11-30T17:39:37ZJonathan CLARKEjonathan.clarke@normation.com
<ul><li><strong>Status</strong> changed from <i>In progress</i> to <i>Pending technical review</i></li><li><strong>Assignee</strong> changed from <i>Jonathan CLARKE</i> to <i>Benoît PECCATTE</i></li><li><strong>Pull Request</strong> set to <i>https://github.com/Normation/rudder-techniques/pull/809</i></li></ul><p>PR <a class="external" href="https://github.com/Normation/rudder-techniques/pull/809">https://github.com/Normation/rudder-techniques/pull/809</a></p> Rudder - Bug #7508: The rudder-agent cron on AIX uses if then, which makes some security test failshttps://issues.rudder.io/issues/7508?journal_id=484832015-11-30T18:02:18ZJonathan CLARKEjonathan.clarke@normation.com
<ul><li><strong>Status</strong> changed from <i>Pending technical review</i> to <i>Pending release</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Applied in changeset <a class="changeset" title="Fixes #7508: The rudder-agent cron on AIX uses if then, which makes some security test fails" href="https://issues.rudder.io/projects/rudder/repository/rudder-techniques/revisions/e0a3bc381bce3bf418867934b948b17d61219b69">rudder-techniques|e0a3bc381bce3bf418867934b948b17d61219b69</a>.</p> Rudder - Bug #7508: The rudder-agent cron on AIX uses if then, which makes some security test failshttps://issues.rudder.io/issues/7508?journal_id=484842015-11-30T18:02:20ZNicolas CHARLESnicolas.charles@rudder.io
<ul></ul><p>Applied in changeset <a class="changeset" title="Merge pull request #809 from jooooooon/bug_7508/the_rudder_agent_cron_on_aix_uses_if_then_which_m..." href="https://issues.rudder.io/projects/rudder/repository/rudder-techniques/revisions/a6e8e3420ff286ef54d18fc4e4947de6fff726d8">rudder-techniques|a6e8e3420ff286ef54d18fc4e4947de6fff726d8</a>.</p> Rudder - Bug #7508: The rudder-agent cron on AIX uses if then, which makes some security test failshttps://issues.rudder.io/issues/7508?journal_id=485682015-12-01T21:42:58ZNicolas CHARLESnicolas.charles@rudder.io
<ul></ul><p>Actually, using the whole path would even be better !</p> Rudder - Bug #7508: The rudder-agent cron on AIX uses if then, which makes some security test failshttps://issues.rudder.io/issues/7508?journal_id=485702015-12-01T21:45:07ZNicolas CHARLESnicolas.charles@rudder.io
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-16 priority-default closed" href="/issues/7525">Bug #7525</a>: Use whole path to binaries in cron from check-rudder-agent on AIX</i> added</li></ul> Rudder - Bug #7508: The rudder-agent cron on AIX uses if then, which makes some security test failshttps://issues.rudder.io/issues/7508?journal_id=496542015-12-10T15:07:13ZVincent MEMBRÉvme@rudder.io
<ul><li><strong>Status</strong> changed from <i>Pending release</i> to <i>Released</i></li></ul><p>This bug has been fixed in Rudder 2.10.20, 2.11.17, 3.0.12 and 3.1.5 which were released today. </p>
<ul>
<li>2.10: <a href="http://www.rudder-project.org/pipermail/rudder-announce/2015-December/000173.html" class="external">Announce</a> <a href="http://www.rudder-project.org/foswiki/bin/view/System/Documentation:ChangeLog210" class="external">Changelog</a></li>
<li>2.11: <a href="http://www.rudder-project.org/pipermail/rudder-announce/2015-December/000172.html" class="external">Announce</a> <a href="http://www.rudder-project.org/foswiki/bin/view/System/Documentation:ChangeLog211" class="external">Changelog</a></li>
<li>3.0: <a href="http://www.rudder-project.org/pipermail/rudder-announce/2015-December/000171.html" class="external">Announce</a> <a href="http://www.rudder-project.org/foswiki/bin/view/System/Documentation:ChangeLog30" class="external">Changelog</a></li>
<li>3.1: <a href="http://www.rudder-project.org/pipermail/rudder-announce/2015-December/000170.html" class="external">Announce</a> <a href="http://www.rudder-project.org/foswiki/bin/view/System/Documentation:ChangeLog31" class="external">Changelog</a></li>
<li>Download: <a class="external" href="https://www.rudder-project.org/site/get-rudder/downloads/">https://www.rudder-project.org/site/get-rudder/downloads/</a></li>
</ul>