Actions
Bug #7519
closedhttp_request_* can't fallback on wget and doesn't warn if curl is missing
Pull Request:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Name check:
Fix check:
Regression:
Description
If you try to use file_download.cf without curl or wget installed, it provides a nice report:
R: [ERROR] Promise could not be repaired, error encountered: Unable to download http://www.normation.com/robots.txt: neither wget or curl are installed
However, http_request_check_status_headers fails without a clear explanation:
error: Command related to promiser '${paths.path[curl]}' returned code defined as promise failed 1 notice: Q: "...ath[curl]} -I -": sh: ${paths.path[curl]}: bad substitution error: Method 'http_request_check_status_headers' failed in some repairs error: Command related to promiser '${paths.path[curl]}' returned code defined as promise failed 1 notice: Q: "...ath[curl]} -I -": sh: ${paths.path[curl]}: bad substitution error: Method 'http_request_check_status_headers' failed in some repairs
For consistency, and for general ease of use, we should test that curl is available before using it, and preferably fallback on wget if it's available too.
Updated by Jonathan CLARKE almost 9 years ago
- Subject changed from http_request_check_status_headers can't fallback on wget and doesn't warn if curl is missing to http_request_* can't fallback on wget and doesn't warn if curl is missing
Several methods are concerned:
- http_request_check_status_headers
- http_request_content_headers
Updated by Jonathan CLARKE almost 9 years ago
- Related to Bug #7521: Tests do not work on AIX added
Updated by Jonathan CLARKE almost 9 years ago
- Status changed from New to In progress
- Assignee set to Jonathan CLARKE
Updated by Jonathan CLARKE almost 9 years ago
- Status changed from In progress to Pending technical review
- Assignee changed from Jonathan CLARKE to Benoît PECCATTE
- Pull Request set to https://github.com/Normation/ncf/pull/285
Updated by Jonathan CLARKE almost 9 years ago
- Status changed from Pending technical review to Pending release
- % Done changed from 0 to 100
Applied in changeset commit:09a20a6755991c5b716fe5de8a0b258ae13c8790.
Updated by Benoît PECCATTE almost 9 years ago
Applied in changeset commit:d2fee894673cd8e30ad6f896cdecc439abffad64.
Updated by Vincent MEMBRÉ about 8 years ago
- Status changed from Pending release to Released
Updated by Alexis Mousset over 2 years ago
- Target version changed from 0.x to ncf-0.x
- Priority set to 0
Updated by Alexis Mousset over 2 years ago
- Project changed from 41 to Rudder
- Category set to Generic methods
Actions