Project

General

Profile

Actions

Enhancement #7526

closed

Housekeeping of /var/rudder/inventories/received|failed|etc

Added by Janos Mattyasovszky about 9 years ago. Updated almost 2 years ago.

Status:
Released
Priority:
N/A
Category:
Web - Nodes & inventories
Target version:
UX impact:
Suggestion strength:
User visibility:
Effort required:
Name check:
Fix check:
Checked
Regression:
No

Description

Please consider some Housekeeping of /var/rudder/inventories/received, as apparently there is no removal of old but successfully uploaded inventories.

Other directories should have the same housekeeping, there is no use keeping failed inventories for years.


Subtasks 1 (0 open1 closed)

Enhancement #22226: Typo and missing log info in cleaning old inventory file parent ticketReleasedVincent MEMBRÉActions

Related issues 1 (0 open1 closed)

Related to Rudder - Question #9719: Node deletes are not properly cleaned upResolvedActions
Actions #1

Updated by François ARMAND over 8 years ago

There is no garbage collection on inventories. The idea was that it was good to find if a node/inventory have had an inventory processed at some point. But I clearly see how it is useless to keep them all, and even dangerous (ever growing directories are generally not a so good idea).

So, what wouls you think be a good clean-up frequency? Configurable or not?

Without too much thinking, it seems that deleting inventories older than 1 month would be ok as a default, with an user configurable option in the admin screen.

Actions #2

Updated by Janos Mattyasovszky almost 8 years ago

  • Related to Question #9719: Node deletes are not properly cleaned up added
Actions #3

Updated by Benoît PECCATTE almost 8 years ago

  • Tracker changed from Bug to User story
Actions #4

Updated by Benoît PECCATTE almost 7 years ago

  • Target version set to Ideas (not version specific)
Actions #5

Updated by Alexis Mousset almost 3 years ago

  • Category changed from Techniques to Web - Nodes & inventories
Actions #6

Updated by François ARMAND almost 3 years ago

Now that we store node content in `/var/rudder/fact-repository/nodes`, we should just delete inventories older that say 1 month in inventories sub directories.

Actions #7

Updated by François ARMAND almost 3 years ago

  • Tracker changed from User story to Enhancement
Actions #8

Updated by François ARMAND almost 2 years ago

  • Subject changed from Housekeeping of /var/rudder/inventories/received to Housekeeping of /var/rudder/inventories/received|failed|etc
  • Description updated (diff)
  • Target version changed from Ideas (not version specific) to 7.2.4
  • Regression set to No
Actions #9

Updated by François ARMAND almost 2 years ago

  • Status changed from New to In progress
  • Assignee set to François ARMAND
Actions #10

Updated by François ARMAND almost 2 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/4616
Actions #11

Updated by François ARMAND almost 2 years ago

Both /var/rudder/inventories/{incoming,accepted-nodes-updates} are housekept along with new inventories (the batch that look for inventories missed by inotify).

Actions #12

Updated by Anonymous almost 2 years ago

  • Status changed from Pending technical review to Pending release
Actions #13

Updated by François ARMAND almost 2 years ago

  • Subtask #22226 added
Actions #14

Updated by Elaad FURREEDAN almost 2 years ago

  • Fix check set to Checked
Actions #15

Updated by Vincent MEMBRÉ almost 2 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 7.2.4 which was released today.

Actions

Also available in: Atom PDF