Project

General

Profile

Actions
Copy link

Bug #7556

closed

Some patches silently fail to apply

Added by Jonathan CLARKE over 8 years ago. Updated over 8 years ago.

Status:
Released
Priority:
1
Assignee:
Benoît PECCATTE
Category:
Packaging
Target version:
2.11.17
Pull Request:
https://github.com/Normation/rudder-p...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

See this output from the build logs:

12:11:56 Applying patches/cfengine/0018-do-not-remove-cflags-when-compiling.patch...
12:11:56 patching file configure.ac
12:11:56 Reversed (or previously applied) patch detected!  Assume -R? [n] 
12:11:56 Apply anyway? [n] 
12:11:56 Skipping patch.
12:11:56 1 out of 1 hunk ignored -- saving rejects to file configure.ac.rej
...
12:11:56 Applying patches/cfengine/07-define-classes-when-package-is-up-to-date.patch...
12:11:56 patching file cf-agent/verify_packages.c
12:11:56 Reversed (or previously applied) patch detected!  Assume -R? [n] 
12:11:56 Apply anyway? [n] 
12:11:56 Skipping patch.
12:11:56 1 out of 1 hunk ignored -- saving rejects to file cf-agent/verify_packages.c.rej

This is occuring in 3.0.* but should be fixed on earlier branches too.

Subtasks 1 (0 open — 1 closed)

Bug #7581: Remove unapplying patchesReleasedVincent MEMBRÉ2015-12-08Actions

Related issues 1 (0 open — 1 closed)

Related to Rudder - Bug #7803: Test for non-applying patches on rudder-jetty and rudder-agent-thin is brokenReleasedVincent MEMBRÉ2016-01-19Actions
Actions
Copy link
 #1

Updated by Jonathan CLARKE over 8 years ago

  • Subject changed from Some patched on rudder-agent silently fail to apply to Some patches on rudder-agent silently fail to apply
Actions
Copy link
 #2

Updated by Jonathan CLARKE over 8 years ago

  • Status changed from New to In progress
  • Assignee set to Jonathan CLARKE
Actions
Copy link
 #3

Updated by Jonathan CLARKE over 8 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Jonathan CLARKE to Benoît PECCATTE
  • Pull Request set to https://github.com/Normation/rudder-packages/pull/829
Actions
Copy link
 #4

Updated by Jonathan CLARKE over 8 years ago

  • Subject changed from Some patches on rudder-agent silently fail to apply to Some patches silently fail to apply

Actually, this could be the case on more packages. I'll add the check to everywhere we apply patches.

Actions
Copy link
 #5

Updated by Jonathan CLARKE over 8 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
Actions
Copy link
 #7

Updated by Vincent MEMBRÉ over 8 years ago

  • Category changed from Agent to Packaging
Actions
Copy link
 #8

Updated by Vincent MEMBRÉ over 8 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.11.17, 3.0.12 and 3.1.5 which were released today.

Actions
Copy link
 #9

Updated by Jonathan CLARKE about 8 years ago

  • Related to Bug #7803: Test for non-applying patches on rudder-jetty and rudder-agent-thin is broken added
Actions
Copy link

Also available in: Atom PDF