Project

General

Profile

Actions

Bug #7560

closed

Bug #7557: Promises are not regenerated during upgrade

Reload technique API call must be synchrone

Added by François ARMAND almost 9 years ago. Updated almost 9 years ago.

Status:
Released
Priority:
1 (highest)
Category:
Web - Config management
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

There is not advantage to have technique reload asynchrone safe the gain in time (but reloading techniques takes hundred of millesonds, not of seconds) and we are getting bugs on bugs on it. And it is very surprising for an user to have a "OK" with an error in logs.

So just make it synchrone, and be done with it.


Subtasks 1 (0 open1 closed)

Bug #7562: Reload technique API call must be synchrone (cfclerk part)ReleasedVincent MEMBRÉ2015-12-08Actions

Related issues 1 (0 open1 closed)

Related to Rudder - Bug #5685: Raise errors if there's issues with a technique created with ncf-builderRejectedActions
Actions #1

Updated by François ARMAND almost 9 years ago

  • Related to Bug #5685: Raise errors if there's issues with a technique created with ncf-builder added
Actions #2

Updated by François ARMAND almost 9 years ago

OK, so actually, the call is ALREADY synchrone.

The problem in the parent ticket is that the callbacks error are not bulling-up to the command results, what is strange.

It makes sense that an error in one callback does not stop the call to other callback. But any error should be reported and change the global result of the command.

Actions #3

Updated by François ARMAND almost 9 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from François ARMAND to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/987
Actions #4

Updated by François ARMAND almost 9 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
Actions #6

Updated by Vincent MEMBRÉ almost 9 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.11.17, 3.0.12 and 3.1.5 which were released today.

Actions

Also available in: Atom PDF