Project

General

Profile

Actions
Copy link

Bug #7581

closed

Bug #7556: Some patches silently fail to apply

Remove unapplying patches

Added by Vincent MEMBRÉ almost 9 years ago. Updated almost 9 years ago.

Status:
Released
Priority:
1 (highest)
Assignee:
Vincent MEMBRÉ
Category:
Packaging
Target version:
3.0.12
Pull Request:
https://github.com/Normation/rudder-p...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

Some patches cannot be applied anymore:

In 3.0:

Applying patches/cfengine/0018-do-not-remove-cflags-when-compiling.patch...
patching file configure.ac
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file configure.ac.rej

commit fdc600e1f3c2ffc109efd980b2a83b45950a774c in cfengine remove the line of patch patches/cfengine/0018-do-not-remove-cflags-when-compiling.patch

This has apparently already been fixed in 3.6.3 (CFEngine version we use in Rudder 3.0) so is no longer necessary.

Also:

Applying patches/cfengine/0017-define-classes-when-package-is-up-to-date.patch...
patching file cf-agent/verify_packages.c
Hunk #1 succeeded at 1692 (offset 7 lines).

[...]

Applying patches/cfengine/07-define-classes-when-package-is-up-to-date.patch...
patching file cf-agent/verify_packages.c
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file cf-agent/verify_packages.c.rej

This is a duplicate patch from #7002 and #6996.

Actions
Copy link
 #1

Updated by Vincent MEMBRÉ almost 9 years ago

  • Parent task set to #7556
Actions
Copy link
 #2

Updated by Vincent MEMBRÉ almost 9 years ago

  • Category set to Packaging
  • Assignee set to Vincent MEMBRÉ
  • Priority changed from N/A to 1 (highest)
  • Target version set to 3.0.12
Actions
Copy link
 #3

Updated by Jonathan CLARKE almost 9 years ago

  • Description updated (diff)
  • Status changed from New to In progress
Actions
Copy link
 #4

Updated by Jonathan CLARKE almost 9 years ago

  • Assignee changed from Vincent MEMBRÉ to Jonathan CLARKE
Actions
Copy link
 #5

Updated by Jonathan CLARKE almost 9 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Jonathan CLARKE to Benoît PECCATTE
  • Pull Request set to https://github.com/Normation/rudder-packages/pull/835
Actions
Copy link
 #6

Updated by Jonathan CLARKE almost 9 years ago

  • Assignee changed from Benoît PECCATTE to Vincent MEMBRÉ
Actions
Copy link
 #7

Updated by Jonathan CLARKE almost 9 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
Actions
Copy link
 #9

Updated by Vincent MEMBRÉ almost 9 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 3.0.12 and 3.1.5 which were released today.

Actions
Copy link

Also available in: Atom PDF