Project

General

Profile

Bug #7623

Unexpected reports using "rpmPackageInstallation" technique

Added by Jonathan CLARKE about 4 years ago. Updated about 4 years ago.

Status:
Released
Priority:
N/A
Category:
Techniques
Target version:
Severity:
User visibility:
Effort required:
Priority:

Description

Sometime both a repaired and a success message can come through. This is due to poor checking of the result classes.

Associated revisions

Revision 0acf048e (diff)
Added by Jonathan CLARKE about 4 years ago

Fixes #7623: Unexpected reports using "rpmPackageInstallation" technique

Revision 472db245
Added by Nicolas CHARLES about 4 years ago

Merge pull request #840 from jooooooon/bug_7623/unexpected_reports_using_rpmpackageinstallation_technique

Fixes #7623: Unexpected reports using \"rpmPackageInstallation\" technique

History

#1

Updated by Jonathan CLARKE about 4 years ago

  • Status changed from New to In progress
  • Assignee set to Jonathan CLARKE
#2

Updated by Jonathan CLARKE about 4 years ago

  • Tags set to Quick and important
#3

Updated by Benoît PECCATTE about 4 years ago

  • Assignee changed from Jonathan CLARKE to Benoît PECCATTE
#4

Updated by Benoît PECCATTE about 4 years ago

  • Status changed from In progress to Discussion
  • Assignee changed from Benoît PECCATTE to Jonathan CLARKE

There are 12 versions of the technique in 2.11 which are all broken in a different way.
This doesn't seem quick for me.

#5

Updated by Jonathan CLARKE about 4 years ago

  • Status changed from Discussion to Pending technical review
  • Assignee changed from Jonathan CLARKE to Nicolas CHARLES
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/840
#6

Updated by Jonathan CLARKE about 4 years ago

Benoît PECCATTE wrote:

There are 12 versions of the technique in 2.11 which are all broken in a different way.
This doesn't seem quick for me.

Actually they are all broken in the exact same way, for this bug. I wrote the fix once and copy/pasted it to all versions - except the latest, which uses our shared reporting library, so I just changed that to use the "generic" method, that avoids this bug anyway.

#7

Updated by Jonathan CLARKE about 4 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
#8

Updated by Vincent MEMBRÉ about 4 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.11.18, 3.0.13, 3.1.6 and 3.2.0 which were released today.

Also available in: Atom PDF