Project

General

Profile

Actions

Architecture #7634

closed

Make NodeInfo more dependant on Node

Added by Vincent MEMBRÉ about 9 years ago. Updated almost 9 years ago.

Status:
Released
Priority:
4
Category:
Architecture - Code maintenance
Target version:
Effort required:
Name check:
Fix check:
Regression:

Description

We have two classes for almost the same thing in Scala (NodeInfo and Node) and it makes me crazy

If we update Node, we have to update NodeInfo (who has more informations)

#7628 is a consequence of this behavior ...

Maybe we should have only one Node class with all informations, but for now i will only add a Node as parameter in NodeInfo and remove all redundant parameter


Related issues 1 (0 open1 closed)

Related to Rudder - Bug #7628: compilation error after #7061ReleasedNicolas CHARLES2015-12-16Actions
Actions #1

Updated by Vincent MEMBRÉ about 9 years ago

  • Status changed from New to In progress
Actions #2

Updated by Vincent MEMBRÉ about 9 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Vincent MEMBRÉ to François ARMAND
  • Pull Request set to https://github.com/Normation/rudder/pull/1009
Actions #3

Updated by Vincent MEMBRÉ almost 9 years ago

  • Related to Bug #7628: compilation error after #7061 added
Actions #4

Updated by Vincent MEMBRÉ almost 9 years ago

  • Target version changed from 4.0.0~rc2 to 2.11.18
Actions #5

Updated by Vincent MEMBRÉ almost 9 years ago

  • Pull Request deleted (https://github.com/Normation/rudder/pull/1009)
Actions #6

Updated by Vincent MEMBRÉ almost 9 years ago

  • Pull Request set to https://github.com/Normation/rudder/pull/1022
Actions #7

Updated by Vincent MEMBRÉ almost 9 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
Actions #8

Updated by Vincent MEMBRÉ almost 9 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.11.18, 3.0.13, 3.1.6 and 3.2.0 which were released today.

Actions

Also available in: Atom PDF