Project

General

Profile

Actions

Bug #7679

closed

All the files in /opt/rudder/share/tools should not be executable

Added by Alexis MOUSSET over 5 years ago. Updated about 5 years ago.

Status:
Released
Priority:
N/A
Category:
Packaging
Target version:
Severity:
User visibility:
Effort required:
Priority:

Description

From 'rudder-techniques/debian/postinst':

chmod 755 -R /opt/rudder/share/tools

root@server:/var/rudder/tools# ll /opt/rudder/share/tools/
total 17296
-rwxr-xr-x 1 root root     1229 Dec  3 23:42 apache-vhost.tpl
-rwxr-xr-x 1 root root     1946 Dec  3 23:42 checkroute.pl
-rwxr-xr-x 1 root root      713 Dec  3 23:42 check-rsyslog-version
-rwxr-xr-x 1 root root     1083 Dec  3 23:42 checkzmd.pl
-rwxr-xr-x 1 root root     1024 Dec  3 23:42 check-zypper-version
-rwxr-xr-x 1 root root     3809 Dec  3 23:42 cpuid-android-V1.0.sh
-rwxr-xr-x 1 root root     3793 Dec  3 23:42 cpuid-linux-V1.0.sh
-rwxr-xr-x 1 root root     4617 Dec  3 23:42 cpuid-windows-v1.0.vbs
drwxr-xr-x 2 root root     4096 Dec 22 11:08 curl
-rwxr-xr-x 1 root root 12264090 Dec  3 23:42 fusionagent.exe
-rwxr-xr-x 1 root root      542 Dec  3 23:42 getDate.bat
-rwxr-xr-x 1 root root   888832 Dec  3 23:42 iconv.dll
-rwxr-xr-x 1 root root     7680 Dec  3 23:42 iconv.exe
-rwxr-xr-x 1 root root  3633152 Dec  3 23:42 nxlog-ce-2.8.1248.msi
-rwxr-xr-x 1 root root     1574 Dec  3 23:42 nxlog.conf
drwxr-xr-x 2 root root     4096 Dec 22 11:08 openssl
-rwxr-xr-x 1 root root   397383 Dec  3 23:42 openvpn-2.2.1-1.i686.rpm
-rwxr-xr-x 1 root root   426212 Dec  3 23:42 openvpn-2.2.1-1.x86_64.rpm
-rwxr-xr-x 1 root root      683 Dec  3 23:42 registrydns.bat
-rwxr-xr-x 1 root root      275 Dec  3 23:42 run-inventory.bat
-rwxr-xr-x 1 root root     2916 Dec  3 23:42 send-clean.sh
-rwxr-xr-x 1 root root      316 Dec  3 23:42 userlist.bat
-rwxr-xr-x 1 root root      345 Dec  3 23:42 uuid.vbs
-rwxr-xr-x 1 root root      372 Dec  3 23:42 vmware_info.sh
-rwxr-xr-x 1 root root      592 Dec  3 23:42 zypper-repo.tpl

Templates, configuration files and packages should not be executable.


Subtasks 1 (0 open1 closed)

Bug #7765: All the files in /opt/rudder/share/tools should not be executable in the RPM packageRejected2016-01-13Actions

Related issues

Related to Rudder - Bug #7644: Permissions of rudder tools are not preserved on relaysReleasedNicolas CHARLES2015-12-28Actions
Actions #1

Updated by Alexis MOUSSET over 5 years ago

  • Related to Bug #7644: Permissions of rudder tools are not preserved on relays added
Actions #2

Updated by Alexis MOUSSET over 5 years ago

The rights of the files in the repo seem better:

amousset@amo ~/R/rudder-techniques> ll tools/
total 17M
-rw-r--r--. 1 amousset amousset 1.3K Dec 21 15:25 apache-vhost.tpl
-rwxr-xr-x. 1 amousset amousset 2.0K Dec 21 15:25 checkroute.pl*
-rwxr-xr-x. 1 amousset amousset  713 Dec 21 15:25 check-rsyslog-version*
-rwxr-xr-x. 1 amousset amousset 1.1K Dec 21 15:25 checkzmd.pl*
-rwxr-xr-x. 1 amousset amousset 1.0K Dec 21 15:25 check-zypper-version*
-rw-r--r--. 1 amousset amousset 3.8K Dec 21 15:25 cpuid-android-V1.0.sh
-rw-r--r--. 1 amousset amousset 3.8K Dec 21 15:25 cpuid-linux-V1.0.sh
-rw-r--r--. 1 amousset amousset 4.6K Dec 21 15:25 cpuid-windows-v1.0.vbs
drwxr-xr-x. 2 amousset amousset 4.0K Dec 22 14:37 curl/
-rw-r--r--. 1 amousset amousset  12M Dec 21 15:25 fusionagent.exe
-rw-r--r--. 1 amousset amousset  542 Dec 21 15:25 getDate.bat
-rw-r--r--. 1 amousset amousset 868K Dec 21 15:25 iconv.dll
-rw-r--r--. 1 amousset amousset 7.5K Dec 21 15:25 iconv.exe
-rw-r--r--. 1 amousset amousset 3.5M Dec 21 15:25 nxlog-ce-2.8.1248.msi
-rw-r--r--. 1 amousset amousset 1.6K Dec 22 14:37 nxlog.conf
-rw-r--r--. 1 amousset amousset 389K Dec 21 15:25 openvpn-2.2.1-1.i686.rpm
-rw-r--r--. 1 amousset amousset 417K Dec 21 15:25 openvpn-2.2.1-1.x86_64.rpm
-rw-r--r--. 1 amousset amousset  683 Dec 21 15:25 registrydns.bat
-rwxr-xr-x. 1 amousset amousset  275 Dec 21 15:25 run-inventory.bat*
-rwxr-xr-x. 1 amousset amousset 2.2K Dec 22 14:37 send-clean.sh*
-rw-r--r--. 1 amousset amousset  316 Dec 21 15:25 userlist.bat
-rw-r--r--. 1 amousset amousset  345 Dec 21 15:25 uuid.vbs
-rwxr-xr-x. 1 amousset amousset  372 Dec 21 15:25 vmware_info.sh*
-rw-r--r--. 1 amousset amousset  592 Dec 21 15:25 zypper-repo.tpl

Actions #3

Updated by Jonathan CLARKE over 5 years ago

  • Status changed from New to In progress
  • Assignee set to Jonathan CLARKE
Actions #4

Updated by Jonathan CLARKE over 5 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Jonathan CLARKE to Benoît PECCATTE
  • Pull Request set to https://github.com/Normation/rudder-packages/pull/845
Actions #5

Updated by Jonathan CLARKE over 5 years ago

  • Target version changed from 2.11.18 to 3.2.0

This doesn't cause any actual problems currently, so we won't take the risk of changing anything in released versions. Retargeting for 3.2.x

Actions #6

Updated by Jonathan CLARKE over 5 years ago

  • Pull Request changed from https://github.com/Normation/rudder-packages/pull/845 to https://github.com/Normation/rudder-packages/pull/846
Actions #7

Updated by Jonathan CLARKE over 5 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
Actions #9

Updated by Vincent MEMBRÉ about 5 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 3.2.0 which were released today.

Actions

Also available in: Atom PDF