Actions
Bug #7766
closed
Too long directive name breaks directive serialization
Status:
Released
Priority:
1 (highest)
Assignee:
Category:
Web - Config management
Target version:
Pull Request:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:
Description
Having a too long directive name breaks several parts of UI (more than 100 chars long).
This case the xml archive in git repository to be invalid:
What we want:
<displayName>the name of the directive</displayName>
What we got:
<displayName>
the name of the directive
</displayName>
WHen restoring the archive containing this the Directive name is now considered to be on 3 lines instead of one
One of the case, webapp makes a "Server cannot be contacted at this time" when adding/removing that directive from a Rule. (javascript became invalid, a string contains the name of the directive ...)
Improving max length of prettifier should prevent this issue ( Set to Int.max )
triming name when unserialising, will allow to work with broken archive
Updated by Vincent MEMBRÉ almost 9 years ago
- Status changed from New to In progress
- Assignee set to Vincent MEMBRÉ
Updated by Vincent MEMBRÉ almost 9 years ago
- Status changed from In progress to Pending technical review
- Assignee changed from Vincent MEMBRÉ to François ARMAND
- Pull Request set to https://github.com/Normation/rudder/pull/1029
Updated by Vincent MEMBRÉ almost 9 years ago
- Status changed from Pending technical review to Pending release
- % Done changed from 0 to 100
Applied in changeset rudder|06567a2546a9fd7b5e1eda12957c9fd59d7744de.
Updated by Vincent MEMBRÉ almost 9 years ago
- Status changed from Pending release to Released
Actions