https://issues.rudder.io/https://issues.rudder.io/themes/rudder7/favicon/favicon.ico?17096450182016-01-18T10:08:36ZIssue TrackerRudder - Bug #7794: rudder-upgrade edits the wrong ncf.conf file causing transitory invalid promises during upgradeshttps://issues.rudder.io/issues/7794?journal_id=508682016-01-18T10:08:36ZNicolas CHARLESnicolas.charles@rudder.io
<ul></ul><p>this is probably because ncf is updated, promises as well, but the ncf used (in /var/rudder/common/ncf) is still not updated</p> Rudder - Bug #7794: rudder-upgrade edits the wrong ncf.conf file causing transitory invalid promises during upgradeshttps://issues.rudder.io/issues/7794?journal_id=509452016-01-19T15:07:53ZVincent MEMBRÉvme@rudder.io
<ul></ul><p>I have a suggestion here ... maybe if ncf common (/var/ncf/common) was a symlink to /usr/share/ncf/tree it would be ok stright away, removing a need to copy these promises to /var/rudder/ncf/common</p>
<p>(that idea can also be extended to /var/rudder/ncf/local be a symlink to /var/rudder/conf-repo/ncf)</p>
<p>What do you think of these ??</p> Rudder - Bug #7794: rudder-upgrade edits the wrong ncf.conf file causing transitory invalid promises during upgradeshttps://issues.rudder.io/issues/7794?journal_id=509542016-01-19T17:13:14ZVincent MEMBRÉvme@rudder.io
<ul></ul><p>ncf common is updated, but it is still using the old logger (looking for 2 params: Formal = {'message','old_class_prefix'} and it received 4: {'Check if the service httpd is started using ps','service_check_running_httpd','','@{args}'} )</p>
<p>I guess /var/rudder/ncf/common is up to date, but ncf.conf (in /var/rudder/ncf/local is still using the old logger</p> Rudder - Bug #7794: rudder-upgrade edits the wrong ncf.conf file causing transitory invalid promises during upgradeshttps://issues.rudder.io/issues/7794?journal_id=509552016-01-19T17:16:59ZJonathan CLARKEjonathan.clarke@normation.com
<ul></ul><p>Exactly, Vincent, ncf.conf is not updated.</p>
<p>The problem comes from rudder-upgrade, that cleverly was configured to change the logger we used... but, not so cleverly, in the wrong config file:</p>
<pre>
sed -i "s%^loggers=\(.*\)logger_rudder\(.*\)$%loggers=\1log_rudder\2%" ${RUDDER_VAR}/ncf/common/ncf.conf
</pre>
<p>The config file in ncf/common is never read, so this doesn't do anything.</p>
<p>All file edits on ncf.conf are on the wrong file, and have been since 2.11.</p> Rudder - Bug #7794: rudder-upgrade edits the wrong ncf.conf file causing transitory invalid promises during upgradeshttps://issues.rudder.io/issues/7794?journal_id=509562016-01-19T17:17:09ZJonathan CLARKEjonathan.clarke@normation.com
<ul><li><strong>Target version</strong> changed from <i>3.2.0</i> to <i>2.11.18</i></li></ul> Rudder - Bug #7794: rudder-upgrade edits the wrong ncf.conf file causing transitory invalid promises during upgradeshttps://issues.rudder.io/issues/7794?journal_id=509572016-01-19T17:18:14ZJonathan CLARKEjonathan.clarke@normation.com
<ul><li><strong>Subject</strong> changed from <i>upgrade from 3.1.6 to 3.2 causes transitory invalid promises</i> to <i>rudder-upgrade edits the wrong ncf.conf file causing transitory invalid promises during upgrades</i></li></ul> Rudder - Bug #7794: rudder-upgrade edits the wrong ncf.conf file causing transitory invalid promises during upgradeshttps://issues.rudder.io/issues/7794?journal_id=509582016-01-19T17:18:22ZJonathan CLARKEjonathan.clarke@normation.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In progress</i></li><li><strong>Assignee</strong> set to <i>Jonathan CLARKE</i></li></ul> Rudder - Bug #7794: rudder-upgrade edits the wrong ncf.conf file causing transitory invalid promises during upgradeshttps://issues.rudder.io/issues/7794?journal_id=509602016-01-19T17:23:44ZJonathan CLARKEjonathan.clarke@normation.com
<ul></ul><p>Also, the port number editing was overly naive:</p>
<pre>
sed -i "s%^cfengine_port=.*%cfengine_port=5309%" ${RUDDER_VAR}/ncf/common/ncf.conf
</pre>
<p>The problem being that ncf.conf now (as of <a class="issue tracker-1 status-5 priority-7 priority-lowest closed" title="Bug: Enforce the content of the local ncf configuration file from techniques (Released)" href="https://issues.rudder.io/issues/5937">#5937</a>) contains two lines matching that, that should <strong>not</strong> both use port 5309:</p>
<pre>
# Which port should be for CFEngine connections/data transfers
{{#classes.community_edition}}
cfengine_port=5309
{{/classes.community_edition}}
{{#classes.enterprise_edition}}
cfengine_port=5308
{{/classes.enterprise_edition}}
</pre> Rudder - Bug #7794: rudder-upgrade edits the wrong ncf.conf file causing transitory invalid promises during upgradeshttps://issues.rudder.io/issues/7794?journal_id=509612016-01-19T17:23:51ZJonathan CLARKEjonathan.clarke@normation.com
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-7 priority-lowest closed" href="/issues/5937">Bug #5937</a>: Enforce the content of the local ncf configuration file from techniques</i> added</li></ul> Rudder - Bug #7794: rudder-upgrade edits the wrong ncf.conf file causing transitory invalid promises during upgradeshttps://issues.rudder.io/issues/7794?journal_id=509632016-01-19T17:25:09ZJonathan CLARKEjonathan.clarke@normation.com
<ul><li><strong>Status</strong> changed from <i>In progress</i> to <i>Pending technical review</i></li><li><strong>Assignee</strong> changed from <i>Jonathan CLARKE</i> to <i>Vincent MEMBRÉ</i></li><li><strong>Pull Request</strong> set to <i>https://github.com/Normation/rudder-packages/pull/870</i></li></ul><p>PR <a class="external" href="https://github.com/Normation/rudder-packages/pull/870">https://github.com/Normation/rudder-packages/pull/870</a></p> Rudder - Bug #7794: rudder-upgrade edits the wrong ncf.conf file causing transitory invalid promises during upgradeshttps://issues.rudder.io/issues/7794?journal_id=509672016-01-19T18:40:22ZJonathan CLARKEjonathan.clarke@normation.com
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-16 priority-default closed parent" href="/issues/7810">Bug #7810</a>: initial promises don't create /var/rudder/configuration-repository/ncf/ncf.conf </i> added</li></ul> Rudder - Bug #7794: rudder-upgrade edits the wrong ncf.conf file causing transitory invalid promises during upgradeshttps://issues.rudder.io/issues/7794?journal_id=509702016-01-19T18:43:36ZJonathan CLARKEjonathan.clarke@normation.com
<ul><li><strong>Status</strong> changed from <i>Pending technical review</i> to <i>Pending release</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Applied in changeset <a class="changeset" title="Fixes #7794: rudder-upgrade edits the wrong ncf.conf file causing transitory invalid promises dur..." href="https://issues.rudder.io/projects/rudder/repository/rudder-packages/revisions/78de2288b70c0a7e677caebb3d09131b62436623">rudder-packages|78de2288b70c0a7e677caebb3d09131b62436623</a>.</p> Rudder - Bug #7794: rudder-upgrade edits the wrong ncf.conf file causing transitory invalid promises during upgradeshttps://issues.rudder.io/issues/7794?journal_id=515572016-01-22T15:36:16ZVincent MEMBRÉvme@rudder.io
<ul><li><strong>Status</strong> changed from <i>Pending release</i> to <i>Released</i></li></ul><p>This bug has been fixed in Rudder 2.11.18, 3.0.13, 3.1.6 and 3.2.0 which were released today. </p>
<ul>
<li>2.11: <a href="http://www.rudder-project.org/pipermail/rudder-announce/2016-January/000173.html" class="external">Announce</a> <a href="http://www.rudder-project.org/foswiki/bin/view/System/Documentation:ChangeLog211" class="external">Changelog</a></li>
<li>3.0: <a href="http://www.rudder-project.org/pipermail/rudder-announce/2016-January/000174.html" class="external">Announce</a> <a href="http://www.rudder-project.org/foswiki/bin/view/System/Documentation:ChangeLog30" class="external">Changelog</a></li>
<li>3.1: <a href="http://www.rudder-project.org/pipermail/rudder-announce/2016-January/000175.html" class="external">Announce</a> <a href="http://www.rudder-project.org/foswiki/bin/view/System/Documentation:ChangeLog31" class="external">Changelog</a></li>
<li>3.2: <a href="http://www.rudder-project.org/pipermail/rudder-announce/2016-January/000176.html" class="external">Announce</a> <a href="http://www.rudder-project.org/foswiki/bin/view/System/Documentation:ChangeLog32" class="external">Changelog</a></li>
<li>Download: <a class="external" href="https://www.rudder-project.org/site/get-rudder/downloads/">https://www.rudder-project.org/site/get-rudder/downloads/</a></li>
</ul> Rudder - Bug #7794: rudder-upgrade edits the wrong ncf.conf file causing transitory invalid promises during upgradeshttps://issues.rudder.io/issues/7794?journal_id=666702016-11-08T10:11:58ZNicolas CHARLESnicolas.charles@rudder.io
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-6 priority-16 priority-default closed" href="/issues/9639">Bug #9639</a>: When running rudder-init on a fresh server, we get an error that "/var/rudder/ncf/local/ does not exist"</i> added</li></ul> Rudder - Bug #7794: rudder-upgrade edits the wrong ncf.conf file causing transitory invalid promises during upgradeshttps://issues.rudder.io/issues/7794?journal_id=807012017-08-10T15:56:25ZFrançois ARMANDfrancois.armand@rudder.io
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-6 priority-16 priority-default closed" href="/issues/11128">Bug #11128</a>: error: Fatal CFEngine error: Augment scope, formal and actual parameter mismatch is fatal</i> added</li></ul>