Project

General

Profile

Actions

Bug #7803

closed

Test for non-applying patches on rudder-jetty and rudder-agent-thin is broken

Added by Jonathan CLARKE over 5 years ago. Updated over 5 years ago.

Status:
Released
Priority:
N/A
Category:
Packaging
Target version:
Severity:
User visibility:
Effort required:
Priority:

Description

#7556 introduced a test to check for non-applying patches, which works fine in rudder-agent, but does not in rudder-jetty and rudder-agent-thin, because it relies on the "$(FIND)" Makefile variable, which is not set in those packages SOURCES/Makefile, resulting in this error:

03:42:10 # Make sure there were no rejects
03:42:10 test ` . -name \*.rej | wc -l` = 0
03:42:10 /bin/sh: 1: .: -name: not found

This error is however not sufficient to break the build, because all we check is that the number of lines output is equal to 0... which it is, as the error appears on stderr.


Related issues

Related to Rudder - Bug #7556: Some patches silently fail to applyReleasedBenoît PECCATTE2015-12-08Actions
Actions #1

Updated by Jonathan CLARKE over 5 years ago

  • Status changed from New to In progress
Actions #2

Updated by Jonathan CLARKE over 5 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Jonathan CLARKE to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder-packages/pull/867
Actions #3

Updated by Jonathan CLARKE over 5 years ago

  • Related to Bug #7756: Allow to use nightlies from CI in rudder-tests added
Actions #4

Updated by Jonathan CLARKE over 5 years ago

  • Related to deleted (Bug #7756: Allow to use nightlies from CI in rudder-tests)
Actions #5

Updated by Jonathan CLARKE over 5 years ago

  • Related to Bug #7556: Some patches silently fail to apply added
Actions #6

Updated by Jonathan CLARKE over 5 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
Actions #7

Updated by Vincent MEMBRÉ over 5 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.11.18, 3.0.13, 3.1.6 and 3.2.0 which were released today.

Actions

Also available in: Atom PDF