Project

General

Profile

Bug #7962

"Download a file from shared folder" technique doesn't have an explicit default value for "Compare method" (was mtime, now digest)

Added by Jonathan CLARKE over 4 years ago. Updated about 4 years ago.

Status:
Released
Priority:
N/A
Category:
Techniques
Target version:
Severity:
User visibility:
Effort required:
Priority:

Description

The "Download a file from shared folder" technique offers a choice of compare methods to know when to update files: mtime (based on file modification time), digest (based on a hash of the file), binary (byte by byte check), etc.

Currently, because of the layout of the web interface to configure Directives, the first choice in the list is selected "by default", and is "mtime". This causes a lot of issues where a file can be modified by someone on a node, and then Rudder will never update it again because it has a more recent mtime that the one provided by Rudder. This is of course the design intended by the "mtime" option, but does not fit with standard expectations for file copying.

I propose therefore to change the default to "digest", and make it explicit in the technique's metadata.xml.


Subtasks

Bug #7977: Syntax error on #7962Released2016-02-25Jonathan CLARKEActions
Bug #7994: "Download a file from shared folder" technique doesn't have an explicit default value for "Compare method" (was mtime, now digest) - 3.0 branchReleased2016-02-25Benoît PECCATTEActions
Bug #7996: Syntax error on #7962Released2016-02-25Jonathan CLARKEActions
#1

Updated by Jonathan CLARKE over 4 years ago

  • Status changed from New to In progress
#2

Updated by Jonathan CLARKE over 4 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Jonathan CLARKE to Benoît PECCATTE
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/876
#3

Updated by Jonathan CLARKE over 4 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
#4

Updated by Vincent MEMBRÉ about 4 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.11.19, 3.0.14, 3.1.8 and 3.2.1 which were released today.

Also available in: Atom PDF