Project

General

Profile

Actions

User story #8248

closed

Without config changes, two promise generation may lead to differently ordered value in promises

Added by François ARMAND almost 8 years ago. Updated almost 5 years ago.

Status:
Rejected
Priority:
2
Category:
Web - Config management
Target version:
UX impact:
Suggestion strength:
User visibility:
Effort required:
Name check:
Fix check:
Regression:

Description

When debugging #8247, I noticed that other changes are random, creating false cache invalidation. The resutl is correct, because unordered sets of values, but a lot of things are moved around for nothing.

Example (traced with git on /var/rudder/share directory, with word diff, so look for [-xxx-] and {+yyy+}):

+++ b/share/f2ad48f3-66b8-4270-9fd6-cf3c0426034b/rules/cfengine-community/checkGenericFileContent/5.0/checkGenericFileContent.cf
....
@@ -104,8 +104,8 @@ bundle agent check_generic_file_content {
                        "generic_file_content_owner[25]" string => "expd_of";
                        "generic_file_content_owner[26]" string => "root";
                        "generic_file_content_owner[27]" string => "root";
                        "generic_file_content_owner[28]" string => "$([-root-]{+generic_variable_definition.expuser+})";
                        "generic_file_content_owner[29]" string => "[-generic_variable_definition.expuser-]{+root+}";
                        "generic_file_content_owner[30]" string => "root";
                        "generic_file_content_owner[31]" string => "root";
                        "generic_file_content_owner[32]" string => "root";
...

Or:

+++ b/share/f2ad48f3-66b8-4270-9fd6-cf3c0426034b/rules/cfengine-community/copyGitFile/1.5/copyFileFromSharedFolder.cf
@@ -25,8 +25,8 @@ bundle agent download_from_shared_folder
.....
                "copyfile[4][name]" string => "sources/[-drush/drush-]{+postgresql/postgresql+}-$(generic_variable_definition.version_[-drush).tgz-]{+postgresql).run+}";
                "copyfile[5][name]" string => "sources/[-postgresql/postgresql-]{+drush/drush+}-$(generic_variable_definition.version_[-postgresql).run-]{+drush).tgz+}";
.....

Not sur we can do something, because order may have a meaning in the general case, but it's really not clean as it is.


Related issues 1 (0 open1 closed)

Related to Rudder - User story #8247: Changing hostname or policy server of one node force regeneration of all rules on the nodeRejectedFrançois ARMANDActions
Actions #1

Updated by François ARMAND almost 8 years ago

  • Related to User story #8247: Changing hostname or policy server of one node force regeneration of all rules on the node added
Actions #2

Updated by Vincent MEMBRÉ almost 8 years ago

  • Target version changed from 2.11.21 to 2.11.22
Actions #3

Updated by Vincent MEMBRÉ almost 8 years ago

  • Target version changed from 2.11.22 to 2.11.23
Actions #4

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 2.11.23 to 2.11.24
Actions #5

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 2.11.24 to 308
Actions #6

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 308 to 3.1.14
Actions #7

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.1.14 to 3.1.15
Actions #8

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.1.15 to 3.1.16
Actions #9

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.1.16 to 3.1.17
Actions #10

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 3.1.17 to 3.1.18
Actions #11

Updated by Vincent MEMBRÉ about 7 years ago

  • Target version changed from 3.1.18 to 3.1.19
Actions #12

Updated by Benoît PECCATTE about 7 years ago

  • Tracker changed from Bug to User story

Requalifying as user story since everything is working properly, it's just that it could be better

Actions #13

Updated by Vincent MEMBRÉ almost 7 years ago

  • Target version changed from 3.1.19 to 3.1.20
Actions #14

Updated by Vincent MEMBRÉ almost 7 years ago

  • Target version changed from 3.1.20 to 3.1.21
Actions #15

Updated by Vincent MEMBRÉ almost 7 years ago

  • Target version changed from 3.1.21 to 3.1.22
Actions #16

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 3.1.22 to 3.1.23
Actions #17

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 3.1.23 to 3.1.24
Actions #18

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 3.1.24 to 3.1.25
Actions #19

Updated by Benoît PECCATTE over 6 years ago

  • Target version changed from 3.1.25 to 4.1.9
Actions #20

Updated by Vincent MEMBRÉ over 6 years ago

  • Target version changed from 4.1.9 to 4.1.10
Actions #21

Updated by Vincent MEMBRÉ about 6 years ago

  • Target version changed from 4.1.10 to 4.1.11
Actions #22

Updated by Vincent MEMBRÉ almost 6 years ago

  • Target version changed from 4.1.11 to 4.1.12
Actions #23

Updated by Vincent MEMBRÉ almost 6 years ago

  • Target version changed from 4.1.12 to 4.1.13
Actions #24

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 4.1.13 to 4.1.14
Actions #25

Updated by Benoît PECCATTE over 5 years ago

  • Target version changed from 4.1.14 to 4.1.15
Actions #26

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 4.1.15 to 4.1.16
Actions #27

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 4.1.16 to 4.1.17
Actions #28

Updated by Vincent MEMBRÉ over 5 years ago

  • Target version changed from 4.1.17 to 4.1.18
Actions #29

Updated by Vincent MEMBRÉ about 5 years ago

  • Target version changed from 4.1.18 to 4.1.19
Actions #30

Updated by Alexis Mousset about 5 years ago

  • Target version changed from 4.1.19 to 4.1.20
Actions #31

Updated by François ARMAND about 5 years ago

  • Target version changed from 4.1.20 to 4.1.21
Actions #32

Updated by Vincent MEMBRÉ almost 5 years ago

  • Target version changed from 4.1.21 to 4.1.22
Actions #33

Updated by Benoît PECCATTE almost 5 years ago

  • Target version changed from 4.1.22 to 5.0.10
Actions #34

Updated by François ARMAND almost 5 years ago

  • Status changed from In progress to Rejected

This is not the case anymore, and promise generation are deterministic. This is documented here: https://docs.rudder.io/reference/5.0/usage/advanced_configuration_management.html#_directives_ordering

Actions

Also available in: Atom PDF