Bug #8430: logger_rudder can re-read expected_reports_temp even without change, impacting performance significantly - ncf - Rudder Issue Tracker

Bug #8430

Bug #8343: logger_rudder breaks if expected_reports.csv.res is missing but expected_reports.csv.tmp is present

logger_rudder can re-read expected_reports_temp even without change, impacting performance significantly

Added by Jonathan CLARKE over 3 years ago. Updated over 3 years ago.

Status:

Released

Priority:

N/A

Assignee:

Nicolas CHARLES

Category:

Target version:

0.x

Pull Request:

https://github.com/Normation/ncf/pull...

Severity:

User visibility:

Effort required:

Priority:

Description

On one test machine, this took an agent run from 53 seconds to 124.

Somehow, the local classes in bundle logger_rudder can "persist" between calls - I think this is when the bundle is called several times in a single "call". This can be simply worked around using an extra class protection.

Subtasks

Related issues

Associated revisions

Revision adb480d0 (diff)
Added by Jonathan CLARKE over 3 years ago

Fixes #8430: logger_rudder can re-read expected_reports_temp even without change, impacting performance significantly

Revision c0334f9c
Added by Nicolas CHARLES over 3 years ago

Merge pull request #371 from jooooooon/bug_8430/logger_rudder_can_re_read_expected_reports_temp_even_without_change_impacting_performance_significantly

Fixes #8430: logger_rudder can re-read expected_reports_temp even without change, impacting performance significantly