Project

General

Profile

Bug #8430

Bug #8343: logger_rudder breaks if expected_reports.csv.res is missing but expected_reports.csv.tmp is present

logger_rudder can re-read expected_reports_temp even without change, impacting performance significantly

Added by Jonathan CLARKE over 3 years ago. Updated over 3 years ago.

Status:
Released
Priority:
N/A
Category:
-
Target version:
Severity:
User visibility:
Effort required:
Priority:

Description

On one test machine, this took an agent run from 53 seconds to 124.

Somehow, the local classes in bundle logger_rudder can "persist" between calls - I think this is when the bundle is called several times in a single "call". This can be simply worked around using an extra class protection.


Subtasks

Bug #8433: logger_rudder evaluates too late content of temp file, causing it to miss first reportReleasedBenoît PECCATTEActions

Related issues

Related to ncf - Bug #8379: invalid reporting in ncfReleased2016-05-25Actions

Associated revisions

Revision adb480d0 (diff)
Added by Jonathan CLARKE over 3 years ago

Fixes #8430: logger_rudder can re-read expected_reports_temp even without change, impacting performance significantly

Revision c0334f9c
Added by Nicolas CHARLES over 3 years ago

Merge pull request #371 from jooooooon/bug_8430/logger_rudder_can_re_read_expected_reports_temp_even_without_change_impacting_performance_significantly

Fixes #8430: logger_rudder can re-read expected_reports_temp even without change, impacting performance significantly

History

#1

Updated by Jonathan CLARKE over 3 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Jonathan CLARKE to Nicolas CHARLES
  • Pull Request set to https://github.com/Normation/ncf/pull/371
#2

Updated by Jonathan CLARKE over 3 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
#3

Updated by Nicolas CHARLES over 3 years ago

  • Related to Bug #8379: invalid reporting in ncf added
#4

Updated by Vincent MEMBRÉ over 3 years ago

  • Status changed from Pending release to Released

Also available in: Atom PDF