Project

General

Profile

Actions

Bug #8430

closed

Bug #8343: logger_rudder breaks if expected_reports.csv.res is missing but expected_reports.csv.tmp is present

logger_rudder can re-read expected_reports_temp even without change, impacting performance significantly

Added by Jonathan CLARKE over 6 years ago. Updated 4 months ago.

Status:
Released
Priority:
N/A
Category:
Generic methods
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Regression:

Description

On one test machine, this took an agent run from 53 seconds to 124.

Somehow, the local classes in bundle logger_rudder can "persist" between calls - I think this is when the bundle is called several times in a single "call". This can be simply worked around using an extra class protection.


Subtasks 1 (0 open1 closed)

Bug #8433: logger_rudder evaluates too late content of temp file, causing it to miss first reportReleasedBenoît PECCATTEActions

Related issues 1 (0 open1 closed)

Related to Rudder - Bug #8379: invalid reporting in ncfReleasedNicolas CHARLESActions
Actions #1

Updated by Jonathan CLARKE over 6 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Jonathan CLARKE to Nicolas CHARLES
  • Pull Request set to https://github.com/Normation/ncf/pull/371
Actions #2

Updated by Jonathan CLARKE over 6 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Applied in changeset commit:adb480d06e6ba1d5db0dd4c3daa36ad5680f051a.

Actions #3

Updated by Nicolas CHARLES over 6 years ago

  • Related to Bug #8379: invalid reporting in ncf added
Actions #4

Updated by Vincent MEMBRÉ about 6 years ago

  • Status changed from Pending release to Released
Actions #5

Updated by Alexis Mousset 4 months ago

  • Target version changed from 0.x to ncf-0.x
  • Priority set to 0
Actions #6

Updated by Alexis Mousset 4 months ago

  • Category set to Generic methods
Actions

Also available in: Atom PDF